Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6612)

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 2807653002: Ensure default dialog button focus remains after a dialog update. (Closed)
Patch Set: Addressing Devlin's comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
index e36d5b66f5a7d315c54bc203cbd8168555966a25..860d5b38e82594404ea67a56c0d208ca097baa38 100644
--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
@@ -80,6 +80,9 @@ constexpr int kNoPermissionsLeftColumnWidth = 200;
// this case, so make it wider than normal.
constexpr int kExternalInstallLeftColumnWidth = 350;
+// Time delay before the install button is enabled after initial display.
+int g_install_delay_in_ms = 500;
+
// Get the appropriate indentation for an item if its parent is using bullet
// points. If the parent is using bullets for its items, then a padding of one
// unit will make the child item (which has no bullet) look like a sibling of
@@ -91,9 +94,6 @@ int GetLeftPaddingForBulletedItems(bool parent_bulleted) {
(parent_bulleted ? 2 : 1);
}
-// Time delay before the install button is enabled after initial display.
-int g_install_delay_in_ms = 500;
-
void AddResourceIcon(const gfx::ImageSkia* skia_image, void* data) {
views::View* parent = static_cast<views::View*>(data);
views::ImageView* image_view = new views::ImageView();

Powered by Google App Engine
This is Rietveld 408576698