chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 2807653002: Ensure default dialog button focus remains after a dialog update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 2807653002: Ensure default dialog button focus remains after a dialog update. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc » ('j') | chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index e36d5b66f5a7d315c54bc203cbd8168555966a25..188cea3725e5eb28025522bf611fbe066d767b50 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -627,6 +627,7 @@ void ExtensionInstallDialogView::VisibilityChanged(views::View* starting_from,

void ExtensionInstallDialogView::EnableInstallButton() {

install_button_enabled_ = true;

GetDialogClientView()->UpdateDialogButtons();

+ GetInitiallyFocusedView()->RequestFocus();

}

void ExtensionInstallDialogView::UpdateInstallResultHistogram(bool accepted)