Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 280763003: Rename http_transaction_unittest to http_transaction_test_util. (Closed)

Created:
6 years, 7 months ago by eustas
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename http_transaction_unittest to http_transaction_test_util. And move it to test support target. Actually this file contains only utilities for tests, but not tests themselves. BUG=245436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -821 lines) Patch
M net/http/http_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/http/http_transaction_test_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/http/http_transaction_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/http/http_transaction_unittest.h View 1 chunk +0 lines, -306 lines 0 comments Download
D net/http/http_transaction_unittest.cc View 1 chunk +0 lines, -503 lines 0 comments Download
M net/http/mock_http_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_ftp_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
eustas
6 years, 7 months ago (2014-05-13 11:28:37 UTC) #1
rvargas (doing something else)
Thanks for doing this!. LGTM
6 years, 7 months ago (2014-05-13 17:54:33 UTC) #2
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 7 months ago (2014-05-14 04:45:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/280763003/1
6 years, 7 months ago (2014-05-14 04:45:37 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 07:47:24 UTC) #5
Message was sent while issue was closed.
Change committed as 270354

Powered by Google App Engine
This is Rietveld 408576698