Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2807593002: Use entities in impact transformers. (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use entities in impact transformers. This makes the impact transformers reusable for kernel based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/b4ef45d6e4bfba8eba6807305256a06210501b3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -98 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 6 chunks +25 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/common_elements.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 4 chunks +19 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 16 chunks +38 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 4 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 1 chunk +1 line, -9 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-07 14:08:43 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-10 19:22:17 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-11 08:03:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b4ef45d6e4bfba8eba6807305256a06210501b3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698