Add unit tests for the CLD component installer

chrome/browser/translate/translate_tab_helper.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_tab_helper.h"
 
+#include <vector>
+
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_split.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/translate/translate_accept_languages_factory.h"
 #include "chrome/browser/translate/translate_infobar_delegate.h"
 #include "chrome/browser/translate/translate_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 17 matching lines @@
 #include "net/http/http_status_code.h"
 #include "url/gurl.h"
 
 #if defined(CLD2_DYNAMIC_MODE)
 #include "base/files/file.h"
 #include "base/path_service.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
-#include "content/public/browser/render_view_host.h"
 #endif
 
 #if defined(CLD2_IS_COMPONENT)
 #include "chrome/browser/component_updater/cld_component_installer.h"
 #endif
 
 namespace {
 
 // The maximum number of attempts we'll do to see if the page has finshed
 // loading before giving up the translation
@@ skipping 100 matching lines @@
                                          const std::string target_language,
                                          TranslateErrors::Type error_type,
                                          bool triggered_from_menu) {
   DCHECK(web_contents());
   if (error_type != TranslateErrors::NONE)
     step = translate::TRANSLATE_STEP_TRANSLATE_ERROR;
 
   if (TranslateService::IsTranslateBubbleEnabled()) {
     // Bubble UI.
     if (step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {
-      // TODO: Move this logic out of UI code.
+      // TODO(droger): Move this logic out of UI code.
       GetLanguageState().SetTranslateEnabled(true);
       if (!GetLanguageState().HasLanguageChanged())
         return;
     }
     ShowBubble(step, error_type);
     return;
   }
 
   // Infobar UI.
   Profile* profile =
@@ skipping 204 matching lines @@
 
 void TranslateTabHelper::HandleCLDDataRequest() {
   // Because this function involves arbitrary file system access, it must run
   // on the blocking pool.
   DCHECK(!content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
   DCHECK(!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   {
     base::AutoLock lock(s_file_lock_.Get());
     if (s_cached_file_)
-      return; // Already done, duplicate request
+      return;  // Already done, duplicate request
   }
 
+#if defined(CLD2_IS_COMPONENT)
+  base::FilePath path = component_updater::GetLatestCldDataFile();
+  if (path.empty())
+    return;
+#else  // CLD2 data is at a well-known file path
   base::FilePath path;
-#if defined(CLD2_IS_COMPONENT)
-  if (!component_updater::GetLatestCldDataFile(&path))
-    return;
-#else
   if (!PathService::Get(chrome::DIR_USER_DATA, &path)) {
     LOG(WARNING) << "Unable to locate user data directory";
-    return; // Chrome isn't properly installed.
+    return;  // Chrome isn't properly installed.
   }
+  path = path.Append(chrome::kCLDDataFilename);
+#endif
+
   // If the file exists, we can send an IPC-safe construct back to the
-  // renderer process immediately.
-  path = path.Append(chrome::kCLDDataFilename);
+  // renderer process immediately; otherwise, nothing to do here.
   if (!base::PathExists(path))
     return;
-#endif
 
   // Attempt to open the file for reading.
   scoped_ptr<base::File> file(
       new base::File(path, base::File::FLAG_OPEN | base::File::FLAG_READ));
   if (!file->IsValid()) {
     LOG(WARNING) << "CLD data file exists but cannot be opened";
     return;
   }
 
   base::File::Info file_info;
@@ skipping 13 matching lines @@
     if (s_cached_file_) {
       // Idempotence: Racing another request on the blocking pool, abort.
     } else {
       // Else, this request has taken care of it all. Cache all info.
       s_cached_file_ = file.release();
       s_cached_data_offset_ = data_offset;
       s_cached_data_length_ = data_length;
     }
   }
 }
-#endif // defined(CLD2_DYNAMIC_MODE)
+#endif  // defined(CLD2_DYNAMIC_MODE)
 
 void TranslateTabHelper::InitiateTranslation(const std::string& page_lang,
                                              int attempt) {
   if (translate_driver_.GetLanguageState().translation_pending())
     return;
 
   // During a reload we need web content to be available before the
   // translate script is executed. Otherwise we will run the translate script on
   // an empty DOM which will fail. Therefore we wait a bit to see if the page
   // has finished.
@@ skipping 82 matching lines @@
     if (GetLanguageState().InTranslateNavigation())
       return;
   }
 
   TranslateBubbleFactory::Show(
       browser->window(), web_contents(), step, error_type);
 #else
   NOTREACHED();
 #endif
 }