Add unit tests for the CLD component installer

chrome/browser/component_updater/cld_component_installer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/cld_component_installer.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/path_service.h"
-#include "chrome/browser/component_updater/default_component_installer.h"
+#include "base/platform_file.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/ssl/ssl_config_service.h"
 
 using component_updater::ComponentUpdateService;
 using content::BrowserThread;
 
 namespace {
@@ skipping 13 matching lines @@
 // The extension id is: dpedmmgabcgnikllifiidmijgoiihfgf
 const uint8 kPublicKeySHA256[32] = {
     0x3f, 0x43, 0xcc, 0x60, 0x12, 0x6d, 0x8a, 0xbb,
     0x85, 0x88, 0x3c, 0x89, 0x6e, 0x88, 0x75, 0x65,
     0xb9, 0x46, 0x09, 0xe8, 0xca, 0x92, 0xdd, 0x82,
     0x4e, 0x6d, 0x0e, 0xe6, 0x79, 0x8a, 0x87, 0xf5
 };
 
 const char kCldManifestName[] = "CLD2 Data";
 
-class CldComponentInstallerTraits : public ComponentInstallerTraits {
- public:
-  CldComponentInstallerTraits();
-  virtual ~CldComponentInstallerTraits() {}
-
- private:
-  // The following methods override ComponentInstallerTraits.
-  virtual bool CanAutoUpdate() const OVERRIDE;
-  virtual bool OnCustomInstall(const base::DictionaryValue& manifest,
-                               const base::FilePath& install_dir) OVERRIDE;
-  virtual bool VerifyInstallation(
-      const base::FilePath& install_dir) const OVERRIDE;
-  virtual void ComponentReady(
-      const base::Version& version,
-      const base::FilePath& path,
-      scoped_ptr<base::DictionaryValue> manifest) OVERRIDE;
-  virtual base::FilePath GetBaseDirectory() const OVERRIDE;
-  virtual void GetHash(std::vector<uint8>* hash) const OVERRIDE;
-  virtual std::string GetName() const OVERRIDE;
-
-  base::FilePath GetInstalledPath(const base::FilePath& base) const;
-  void SetLatestCldDataFile(const base::FilePath& path);
-  DISALLOW_COPY_AND_ASSIGN(CldComponentInstallerTraits);
-};
-
 CldComponentInstallerTraits::CldComponentInstallerTraits() {
 }
 
 bool CldComponentInstallerTraits::CanAutoUpdate() const {
   return true;
 }
 
 bool CldComponentInstallerTraits::OnCustomInstall(
     const base::DictionaryValue& manifest,
     const base::FilePath& install_dir) {
@@ skipping 48 matching lines @@
 
 void RegisterCldComponent(ComponentUpdateService* cus) {
   scoped_ptr<ComponentInstallerTraits> traits(
       new CldComponentInstallerTraits());
   // |cus| will take ownership of |installer| during installer->Register(cus).
   DefaultComponentInstaller* installer =
       new DefaultComponentInstaller(traits.Pass());
   installer->Register(cus);
 }
 
-// This method is completely threadsafe.
 void CldComponentInstallerTraits::SetLatestCldDataFile(
     const base::FilePath& path) {
   VLOG(1) << "Setting CLD data file location: " << path.value();
   base::AutoLock lock(cld_file_lock.Get());
   cld_file.Get() = path;
 }
 
-bool GetLatestCldDataFile(base::FilePath* path) {
+base::FilePath GetLatestCldDataFile() {
   base::AutoLock lock(cld_file_lock.Get());
-  const base::FilePath cached = cld_file.Get();
-  if (cached.empty())
-    return false;
-  *path = cached;
-  return true;
+  // cld_file is an empty path by default, meaning "file not available yet",

[Sorin Jianu, 2014/05/15 16:03:58]

Excellent!

+  // so we can simply return by value (making a copy).

[Sorin Jianu, 2014/05/15 16:03:58]

@128 Comment not needed as it is both obvious and idiomatic what the getter
does.

[Andrew Hayden (chromium.org), 2014/05/16 12:03:25]

Done.

+  return cld_file.Get();
 }
 
 }  // namespace component_updater