Issue 280753002: Revert of Minor QUIC cleanup to combine QuicUnackedPacketMap's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 280753002: Revert of Minor QUIC cleanup to combine QuicUnackedPacketMap's (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Minor QUIC cleanup to combine QuicUnackedPacketMap's RemovePacket and NeuterPacket into RemoveOrNeuterPacket. Rollback of merge internal change: 66306887 Rollback of Chromium's CL https://codereview.chromium.org/271443008/ *** Reason for rollback *** After further issues with the QUIC handshake packets, rolling back this change in favor of a different approach. *** Original change description *** Minor QUIC cleanup to combine QuicUnackedPacketMap's RemovePacket and NeuterPacket into RemoveOrNeuterPacket. This prevents potential bugs where a packet can be set not pending, then neuter'd, which cuases the packet to never be removed from the unacked packet map. *** Merge internal change: 66573334 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -24 lines)			Patch
M	net/quic/congestion_control/tcp_loss_algorithm_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	4 chunks	+13 lines, -3 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.h	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.cc	View	4 chunks	+30 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages