PRESUBMIT.py - Issue 2807463004: GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2807463004: GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support. (Closed)

Patch Set: rebased, cleaned up the code, addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 819bf7337311411589c2bfb4c872465e76bd1e58..729b427650903cdb8e304eb8e06fcfc8e321ec5a 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -197,6 +197,7 @@ _BANNED_CPP_FUNCTIONS = (

True,

(

r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$",

+ r"^base[\\\/]process[\\\/]internal_aix\.cc$",

r"^base[\\\/]process[\\\/]process_linux\.cc$",

r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",

r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",

@@ -328,6 +329,7 @@ _IPC_ENUM_TRAITS_DEPRECATED = (

_VALID_OS_MACROS = (

# Please keep sorted.

+ 'OS_AIX',

'OS_ANDROID',

'OS_BSD',

'OS_CAT', # For testing.

« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | base/memory/shared_memory_posix.cc » ('J')