OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | 10 |
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
190 ), | 190 ), |
191 ( | 191 ( |
192 'ScopedAllowIO', | 192 'ScopedAllowIO', |
193 ( | 193 ( |
194 'New code should not use ScopedAllowIO. Post a task to the blocking', | 194 'New code should not use ScopedAllowIO. Post a task to the blocking', |
195 'pool or the FILE thread instead.', | 195 'pool or the FILE thread instead.', |
196 ), | 196 ), |
197 True, | 197 True, |
198 ( | 198 ( |
199 r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$", | 199 r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$", |
| 200 r"^base[\\\/]process[\\\/]internal_aix\.cc$", |
200 r"^base[\\\/]process[\\\/]process_linux\.cc$", | 201 r"^base[\\\/]process[\\\/]process_linux\.cc$", |
201 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", | 202 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", |
202 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", | 203 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", |
203 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$", | 204 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$", |
204 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]" | 205 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]" |
205 "customization_document_browsertest\.cc$", | 206 "customization_document_browsertest\.cc$", |
206 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", | 207 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", |
207 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" + | 208 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" + |
208 r"test_info_extractor\.cc$", | 209 r"test_info_extractor\.cc$", |
209 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$", | 210 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$", |
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
321 ) | 322 ) |
322 | 323 |
323 | 324 |
324 _IPC_ENUM_TRAITS_DEPRECATED = ( | 325 _IPC_ENUM_TRAITS_DEPRECATED = ( |
325 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' | 326 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' |
326 'See http://www.chromium.org/Home/chromium-security/education/security-tips-
for-ipc') | 327 'See http://www.chromium.org/Home/chromium-security/education/security-tips-
for-ipc') |
327 | 328 |
328 | 329 |
329 _VALID_OS_MACROS = ( | 330 _VALID_OS_MACROS = ( |
330 # Please keep sorted. | 331 # Please keep sorted. |
| 332 'OS_AIX', |
331 'OS_ANDROID', | 333 'OS_ANDROID', |
332 'OS_BSD', | 334 'OS_BSD', |
333 'OS_CAT', # For testing. | 335 'OS_CAT', # For testing. |
334 'OS_CHROMEOS', | 336 'OS_CHROMEOS', |
335 'OS_FREEBSD', | 337 'OS_FREEBSD', |
336 'OS_IOS', | 338 'OS_IOS', |
337 'OS_LINUX', | 339 'OS_LINUX', |
338 'OS_MACOSX', | 340 'OS_MACOSX', |
339 'OS_NACL', | 341 'OS_NACL', |
340 'OS_NACL_NONSFI', | 342 'OS_NACL_NONSFI', |
(...skipping 2064 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
2405 output_api, | 2407 output_api, |
2406 json_url='http://chromium-status.appspot.com/current?format=json')) | 2408 json_url='http://chromium-status.appspot.com/current?format=json')) |
2407 | 2409 |
2408 results.extend( | 2410 results.extend( |
2409 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) | 2411 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) |
2410 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2412 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
2411 input_api, output_api)) | 2413 input_api, output_api)) |
2412 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2414 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
2413 input_api, output_api)) | 2415 input_api, output_api)) |
2414 return results | 2416 return results |
OLD | NEW |