Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp

Issue 2807433003: No pointer captured when the pointer lock is applied (Closed)
Patch Set: pointer lock Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
diff --git a/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp b/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
index 4657b6dd7d70254b792f20ba32628a4b9454b637..1c3ac90e96a63ada31fa7b6144bef5bfe178d52d 100644
--- a/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
+++ b/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
@@ -238,6 +238,11 @@ Page* WebFrameWidgetBase::GetPage() const {
void WebFrameWidgetBase::DidAcquirePointerLock() {
GetPage()->GetPointerLockController().DidAcquirePointerLock();
+
+ LocalFrame* focusedFrame = FocusedLocalFrameInWidget();
+ if (focusedFrame) {
+ focusedFrame->GetEventHandler().ReleaseMousePointerCapture();
+ }
}
void WebFrameWidgetBase::DidNotAcquirePointerLock() {
@@ -249,10 +254,25 @@ void WebFrameWidgetBase::DidLosePointerLock() {
GetPage()->GetPointerLockController().DidLosePointerLock();
}
-void WebFrameWidgetBase::PointerLockMouseEvent(const WebInputEvent& event) {
+// TODO(665924): Remove direct dispatches of mouse events from
+// PointerLockController, instead passing them through EventHandler.
+void WebFrameWidgetBase::PointerLockMouseEvent(
+ const WebCoalescedInputEvent& coalesced_event) {
+ const WebInputEvent& input_event = coalesced_event.Event();
+ const WebMouseEvent& mouse_event =
+ static_cast<const WebMouseEvent&>(input_event);
+ WebMouseEvent transformed_event = TransformWebMouseEvent(
+ ToWebLocalFrameBase(LocalRoot())->GetFrameView(), mouse_event);
+
+ LocalFrame* focusedFrame = FocusedLocalFrameInWidget();
+ if (focusedFrame) {
+ focusedFrame->GetEventHandler().ProcessPendingPointerCaptureForPointerLock(
+ transformed_event);
+ }
+
std::unique_ptr<UserGestureIndicator> gesture_indicator;
AtomicString event_type;
- switch (event.GetType()) {
+ switch (input_event.GetType()) {
case WebInputEvent::kMouseDown:
event_type = EventTypeNames::mousedown;
if (!GetPage() || !GetPage()->GetPointerLockController().GetElement())
@@ -277,11 +297,7 @@ void WebFrameWidgetBase::PointerLockMouseEvent(const WebInputEvent& event) {
NOTREACHED();
}
- const WebMouseEvent& mouse_event = static_cast<const WebMouseEvent&>(event);
-
if (GetPage()) {
- WebMouseEvent transformed_event = TransformWebMouseEvent(
- ToWebLocalFrameBase(LocalRoot())->GetFrameView(), mouse_event);
GetPage()->GetPointerLockController().DispatchLockedMouseEvent(
transformed_event, event_type);
}
@@ -302,4 +318,11 @@ void WebFrameWidgetBase::ShowContextMenu(WebMenuSourceType source_type) {
}
}
+LocalFrame* WebFrameWidgetBase::FocusedLocalFrameInWidget() const {
+ LocalFrame* frame = GetPage()->GetFocusController().FocusedFrame();
+ return (frame && frame->LocalFrameRoot() == ToCoreFrame(LocalRoot()))
+ ? frame
+ : nullptr;
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h ('k') | third_party/WebKit/Source/core/input/EventHandler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698