Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2807433003: No pointer captured when the pointer lock is applied (Closed)
Patch Set: Change the tests and move code to WebFrameWidgetBase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index af710a5670f2b3475c8303f1f71f48bc76d84b35..2e3a39a28ce2bd838d0a5e96dfbc9a894d4604a0 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -3074,14 +3074,21 @@ void Element::setPointerCapture(int pointer_id,
ExceptionState& exception_state) {
if (GetDocument().GetFrame()) {
if (!GetDocument().GetFrame()->GetEventHandler().IsPointerEventActive(
- pointer_id))
+ pointer_id)) {
exception_state.ThrowDOMException(kInvalidPointerId, "InvalidPointerId");
- else if (!isConnected())
+ } else if (!isConnected()) {
exception_state.ThrowDOMException(kInvalidStateError,
"InvalidStateError");
- else
+ } else if (GetDocument().GetPage() && GetDocument()
mustaq 2017/05/26 14:56:18 Nit: Combine with the above |if| with an OR, since
lanwei 2017/05/29 18:30:07 Done.
+ .GetPage()
+ ->GetPointerLockController()
+ .GetElement()) {
+ exception_state.ThrowDOMException(kInvalidStateError,
+ "InvalidStateError");
+ } else {
GetDocument().GetFrame()->GetEventHandler().SetPointerCapture(pointer_id,
this);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698