No pointer captured when the pointer lock is applied

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2173 matching lines @@
 
   bool is_pointer_locked = false;
   if (WebFrameWidgetBase* widget = MainFrameImpl()->FrameWidget()) {
     if (WebWidgetClient* client = widget->Client())
       is_pointer_locked = client->IsPointerLocked();
   }
 
   if (is_pointer_locked &&
       WebInputEvent::IsMouseEventType(input_event.GetType())) {
     MainFrameImpl()->FrameWidget()->PointerLockMouseEvent(input_event);
+    LocalFrame* focusedFrame = FocusedLocalFrameInWidget();
+
+    if (focusedFrame) {
+      WebMouseEvent transformed_event = TransformWebMouseEvent(
+          MainFrameImpl()->GetFrameView(),
+          static_cast<const WebMouseEvent&>(input_event));
+      Vector<WebMouseEvent> transformed_coalesced_events =
+          TransformWebMouseEventVector(
+              MainFrameImpl()->GetFrameView(),
+              coalesced_event.GetCoalescedEventsPointers());
+      focusedFrame->GetEventHandler().DispatchLostPointerCaptureEvent(

[Navid Zolghadr, 2017/05/17 16:30:11]

This doesn't seem correct. We should have called
PointerEventManager::ProcessPendingPointerCapture before the pointerevent is
sent out instead of this. So basically there are two points here:
1. We added another function (i.e. DispatchLostPointerCaptureEvent) which is in
charge of lostpointercapture instead of reusing what we had
PointerEventManager::ProcessPendingPointerCapture.
2. It seems that this sends out lostpointercapture after the first pointermove
that is sent to the lock element. The lostpointercapture should be sent before
the pointermove.

+          transformed_event, transformed_coalesced_events);
+    }
     return WebInputEventResult::kHandledSystem;
   }
 
   if (mouse_capture_node_ &&
       WebInputEvent::IsMouseEventType(input_event.GetType())) {
     TRACE_EVENT1("input", "captured mouse event", "type",
                  input_event.GetType());
     // Save m_mouseCaptureNode since mouseCaptureLost() will clear it.
     Node* node = mouse_capture_node_;
 
@@ skipping 68 matching lines @@
 }
 
 void WebViewImpl::SetCursorVisibilityState(bool is_visible) {
   if (page_)
     page_->SetIsCursorVisible(is_visible);
 }
 
 void WebViewImpl::MouseCaptureLost() {
   TRACE_EVENT_ASYNC_END0("input", "capturing mouse", this);
   mouse_capture_node_ = nullptr;
+
+  LocalFrame* focusedFrame = FocusedLocalFrameInWidget();
+
+  if (focusedFrame)
+    focusedFrame->GetEventHandler().ReleaseMousePointerCapture();

[Navid Zolghadr, 2017/05/17 16:30:11]

Why do we need to release mouse capture when capture is lost?

[lanwei, 2017/05/19 15:05:00]

This is for the case that we call the setPointerCapture and requestPointerLock,
we should release the pointer capture when we release the pointer lock, so no
gotpointercapture is sent.

 }
 
 void WebViewImpl::SetFocus(bool enable) {
   page_->GetFocusController().SetFocused(enable);
   if (enable) {
     page_->GetFocusController().SetActive(true);
     LocalFrame* focused_frame = page_->GetFocusController().FocusedFrame();
     if (focused_frame) {
       Element* element = focused_frame->GetDocument()->FocusedElement();
       if (element && focused_frame->Selection()
@@ skipping 1877 matching lines @@
   if (focused_frame->LocalFrameRoot() != MainFrameImpl()->GetFrame())
     return nullptr;
   return focused_frame;
 }
 
 LocalFrame* WebViewImpl::FocusedLocalFrameAvailableForIme() const {
   return ime_accept_events_ ? FocusedLocalFrameInWidget() : nullptr;
 }
 
 }  // namespace blink