net/disk_cache/simple/simple_entry_impl.h - Issue 2807433002: SimpleCache: synchronously reply on reads from idle if data is in memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_entry_impl.h

Issue 2807433002: SimpleCache: synchronously reply on reads from idle if data is in memory.

Patch Set: Experimental: upload a bit of an alternative approach for discussion Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_entry_impl.h

diff --git a/net/disk_cache/simple/simple_entry_impl.h b/net/disk_cache/simple/simple_entry_impl.h

index 1484fadcefb4af482c12e27ed14fcc828c6e5141..15ea791521b384ec4e4d20105f95f6e0924058d2 100644

--- a/net/disk_cache/simple/simple_entry_impl.h

+++ b/net/disk_cache/simple/simple_entry_impl.h

@@ -192,11 +192,12 @@ class NET_EXPORT_PRIVATE SimpleEntryImpl : public Entry,

void CloseInternal();

- void ReadDataInternal(int index,

- int offset,

- net::IOBuffer* buf,

- int buf_len,

- const CompletionCallback& callback);

+ int ReadDataInternal(bool try_sync,

+ int index,

+ int offset,

+ net::IOBuffer* buf,

+ int buf_len,

+ const CompletionCallback& callback);

void WriteDataInternal(int index,

int offset,