Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: tools/binary_size/libsupersize/console.py

Issue 2807343005: //tools/binary_size: Record packed .rel.dyn section size (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/binary_size/libsupersize/console.py
diff --git a/tools/binary_size/libsupersize/console.py b/tools/binary_size/libsupersize/console.py
index 34de184af0bf8ab3e2f732641a590d8071ad9ac6..3dbb6a8b3639388c48888c5847a131e8bb2ce31d 100644
--- a/tools/binary_size/libsupersize/console.py
+++ b/tools/binary_size/libsupersize/console.py
@@ -77,11 +77,9 @@ class _Session(object):
if len(size_infos) == 1:
self._variables['size_info'] = size_infos[0]
- self._variables['symbols'] = size_infos[0].symbols
else:
for i, size_info in enumerate(size_infos):
self._variables['size_info%d' % (i + 1)] = size_info
- self._variables['symbols%d' % (i + 1)] = size_info.symbols
def _PrintFunc(self, obj, verbose=False, recursive=False, use_pager=None,
to_file=None):
@@ -150,19 +148,19 @@ class _Session(object):
'Print(size_info, verbose=True)',
'',
'# Show two levels of .text, grouped by first two subdirectories',
- 'text_syms = symbols.WhereInSection("t")',
+ 'text_syms = size_info.symbols.WhereInSection("t")',
'by_path = text_syms.GroupBySourcePath(depth=2)',
'Print(by_path.WhereBiggerThan(1024))',
'',
'# Show all non-vtable generated symbols',
- 'generated_syms = symbols.WhereIsGenerated()',
+ 'generated_syms = size_info.symbols.WhereIsGenerated()',
'Print(generated_syms.WhereNameMatches(r"vtable").Inverted())',
'',
'# Show all symbols that have "print" in their name or path, except',
'# those within components/.',
'# Note: Could have also used Inverted(), as above.',
'# Note: Use "help(ExpandRegex)" for more about what {{_print_}} does.',
- 'print_syms = symbols.WhereMatches(r"{{_print_}}")',
+ 'print_syms = size_info.symbols.WhereMatches(r"{{_print_}}")',
'Print(print_syms - print_syms.WherePathMatches(r"^components/"))',
'',
'# Diff two .size files and save result to a file:',

Powered by Google App Engine
This is Rietveld 408576698