Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: src/builtins/builtins-object.cc

Issue 2807333003: [api] Add DefineProperty() method that skips interceptors.
Patch Set: Previous commit with rebasing Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/v8.h ('K') | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-object.cc
diff --git a/src/builtins/builtins-object.cc b/src/builtins/builtins-object.cc
index 95d2149f31a21e09d506a46bb2fb665d71ea184b..1d80d6335a490524bd3c5a8ca7325f5cd6bc46ed 100644
--- a/src/builtins/builtins-object.cc
+++ b/src/builtins/builtins-object.cc
@@ -102,6 +102,7 @@ Object* ObjectDefineAccessor(Isolate* isolate, Handle<Object> object,
// 3. Let desc be PropertyDescriptor{[[Get]]: getter, [[Enumerable]]: true,
// [[Configurable]]: true}.
PropertyDescriptor desc;
+
if (which_accessor == ACCESSOR_GETTER) {
desc.set_get(accessor);
} else {
@@ -119,7 +120,9 @@ Object* ObjectDefineAccessor(Isolate* isolate, Handle<Object> object,
Maybe<bool> success = JSReceiver::DefineOwnProperty(
isolate, receiver, name, &desc,
FLAG_harmony_strict_legacy_accessor_builtins ? Object::THROW_ON_ERROR
- : Object::DONT_THROW);
+ : Object::DONT_THROW,
+ DONT_SKIP_INTERCEPTORS);
+
MAYBE_RETURN(success, isolate->heap()->exception());
if (!success.FromJust()) {
isolate->CountUsage(v8::Isolate::kDefineGetterOrSetterWouldThrow);
« include/v8.h ('K') | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698