Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: src/builtins/builtins-object.cc

Issue 2807333003: [api] Add DefineProperty() method that skips interceptors.
Patch Set: Previous commit with rebasing Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« include/v8.h ('K') | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins-utils.h" 5 #include "src/builtins/builtins-utils.h"
6 #include "src/builtins/builtins.h" 6 #include "src/builtins/builtins.h"
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stub-assembler.h" 8 #include "src/code-stub-assembler.h"
9 #include "src/counters.h" 9 #include "src/counters.h"
10 #include "src/keys.h" 10 #include "src/keys.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 if (!accessor->IsCallable()) { 95 if (!accessor->IsCallable()) {
96 MessageTemplate::Template message = 96 MessageTemplate::Template message =
97 which_accessor == ACCESSOR_GETTER 97 which_accessor == ACCESSOR_GETTER
98 ? MessageTemplate::kObjectGetterExpectingFunction 98 ? MessageTemplate::kObjectGetterExpectingFunction
99 : MessageTemplate::kObjectSetterExpectingFunction; 99 : MessageTemplate::kObjectSetterExpectingFunction;
100 THROW_NEW_ERROR_RETURN_FAILURE(isolate, NewTypeError(message)); 100 THROW_NEW_ERROR_RETURN_FAILURE(isolate, NewTypeError(message));
101 } 101 }
102 // 3. Let desc be PropertyDescriptor{[[Get]]: getter, [[Enumerable]]: true, 102 // 3. Let desc be PropertyDescriptor{[[Get]]: getter, [[Enumerable]]: true,
103 // [[Configurable]]: true}. 103 // [[Configurable]]: true}.
104 PropertyDescriptor desc; 104 PropertyDescriptor desc;
105
105 if (which_accessor == ACCESSOR_GETTER) { 106 if (which_accessor == ACCESSOR_GETTER) {
106 desc.set_get(accessor); 107 desc.set_get(accessor);
107 } else { 108 } else {
108 DCHECK(which_accessor == ACCESSOR_SETTER); 109 DCHECK(which_accessor == ACCESSOR_SETTER);
109 desc.set_set(accessor); 110 desc.set_set(accessor);
110 } 111 }
111 desc.set_enumerable(true); 112 desc.set_enumerable(true);
112 desc.set_configurable(true); 113 desc.set_configurable(true);
113 // 4. Let key be ? ToPropertyKey(P). 114 // 4. Let key be ? ToPropertyKey(P).
114 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, name, 115 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, name,
115 Object::ToPropertyKey(isolate, name)); 116 Object::ToPropertyKey(isolate, name));
116 // 5. Perform ? DefinePropertyOrThrow(O, key, desc). 117 // 5. Perform ? DefinePropertyOrThrow(O, key, desc).
117 // To preserve legacy behavior, we ignore errors silently rather than 118 // To preserve legacy behavior, we ignore errors silently rather than
118 // throwing an exception. 119 // throwing an exception.
119 Maybe<bool> success = JSReceiver::DefineOwnProperty( 120 Maybe<bool> success = JSReceiver::DefineOwnProperty(
120 isolate, receiver, name, &desc, 121 isolate, receiver, name, &desc,
121 FLAG_harmony_strict_legacy_accessor_builtins ? Object::THROW_ON_ERROR 122 FLAG_harmony_strict_legacy_accessor_builtins ? Object::THROW_ON_ERROR
122 : Object::DONT_THROW); 123 : Object::DONT_THROW,
124 DONT_SKIP_INTERCEPTORS);
125
123 MAYBE_RETURN(success, isolate->heap()->exception()); 126 MAYBE_RETURN(success, isolate->heap()->exception());
124 if (!success.FromJust()) { 127 if (!success.FromJust()) {
125 isolate->CountUsage(v8::Isolate::kDefineGetterOrSetterWouldThrow); 128 isolate->CountUsage(v8::Isolate::kDefineGetterOrSetterWouldThrow);
126 } 129 }
127 // 6. Return undefined. 130 // 6. Return undefined.
128 return isolate->heap()->undefined_value(); 131 return isolate->heap()->undefined_value();
129 } 132 }
130 133
131 Object* ObjectLookupAccessor(Isolate* isolate, Handle<Object> object, 134 Object* ObjectLookupAccessor(Isolate* isolate, Handle<Object> object,
132 Handle<Object> key, AccessorComponent component) { 135 Handle<Object> key, AccessorComponent component) {
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 if (object->IsJSReceiver()) { 521 if (object->IsJSReceiver()) {
519 MAYBE_RETURN(JSReceiver::SetIntegrityLevel(Handle<JSReceiver>::cast(object), 522 MAYBE_RETURN(JSReceiver::SetIntegrityLevel(Handle<JSReceiver>::cast(object),
520 SEALED, Object::THROW_ON_ERROR), 523 SEALED, Object::THROW_ON_ERROR),
521 isolate->heap()->exception()); 524 isolate->heap()->exception());
522 } 525 }
523 return *object; 526 return *object;
524 } 527 }
525 528
526 } // namespace internal 529 } // namespace internal
527 } // namespace v8 530 } // namespace v8
OLDNEW
« include/v8.h ('K') | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698