[api] Add DefineProperty() method that skips interceptors.

test/cctest/test-api-interceptors.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include "test/cctest/test-api.h"
 
 #include "include/v8-util.h"
 #include "src/api.h"
@@ skipping 1798 matching lines @@
       "Object.freeze(obj.x); "
       "Object.isFrozen(obj.x);";
 
   CHECK(v8_compile(code)
             ->Run(env.local())
             .ToLocalChecked()
             ->BooleanValue(env.local())
             .FromJust());
 }
 
+// Check that the descriptor callback is not triggered for DefineProperty

[Franzi, 2017/05/10 09:17:52]

Is this description correct?

I thought we're skipping the definer callback. 

+// when bypass_interceptor = true
+THREADED_TEST(DefinerCallbackWithoutDescriptorInterceptor) {
+  v8::Isolate* isolate = CcTest::isolate();
+  v8::HandleScope scope(isolate);
+  v8::Local<v8::ObjectTemplate> templ = ObjectTemplate::New(isolate);
+
+  templ->SetHandler(v8::NamedPropertyHandlerConfiguration(
+      nullptr, nullptr, PropertyDescriptorCallback, nullptr, nullptr,
+      NotInterceptingPropertyDefineCallback));

[Franzi, 2017/05/10 09:17:52]

This tests seems to make more sense if you set an interceptor that actually
intercepts. And then check that the interceptor is not triggered. If the
interceptor doesn't do anything it's hard to show that it was not called. 

+
+  LocalContext context;
+  v8::Local<v8::Name> p;
+
+  v8::Local<v8::Object> obj =
+      templ->NewInstance(context.local()).ToLocalChecked();
+
+  descriptor_was_called = 0;
+
+  // bypass_interceptor = false (default) triggers the descriptor callback
+  // Use a generic descriptor.
+  v8::PropertyDescriptor desc_generic;
+
+  p = v8_str("v1");
+
+  CHECK(obj->DefineProperty(context.local(), p, desc_generic).FromJust());
+  CHECK_EQ(1, descriptor_was_called);
+
+  descriptor_was_called = 0;
+
+  // bypass_interceptor = true does not trigger the descriptor callback
+  p = v8_str("v2");

[Franzi, 2017/05/10 09:17:52]

Why are you using a different p here?

+
+  CHECK(obj->DefineProperty(context.local(), p, desc_generic, true).FromJust());
+  CHECK_EQ(0, descriptor_was_called);
+}
+
 // Check that the descriptor passed to the callback is enumerable.
 namespace {
 void CheckEnumerablePropertyDefineCallback(
     Local<Name> name, const v8::PropertyDescriptor& desc,
     const v8::PropertyCallbackInfo<v8::Value>& info) {
   CHECK(desc.has_value());
   CHECK_EQ(42, desc.value()
                    ->Int32Value(info.GetIsolate()->GetCurrentContext())
                    .FromJust());
   CHECK(desc.has_enumerable());
@@ skipping 3185 matching lines @@
             ->Set(env.local(), v8_str("Fun"),
                   fun_templ->GetFunction(env.local()).ToLocalChecked())
             .FromJust());
 
   CompileRun(
       "var f = new Fun();"
       "Number.prototype.__proto__ = f;"
       "var a = 42;"
       "for (var i = 0; i<3; i++) { a.foo; }");
 }