components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm - Issue 2807283002: [Cronet] Build static libcronet.a for iOS with complete dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm

Issue 2807283002: [Cronet] Build static libcronet.a for iOS with complete dependencies. (Closed)

Patch Set: Remove cronet_sample, make cronet_consumer_static buildable with lib_cronet. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/ios/cronet_consumer/BUILD.gn ('K') | « components/cronet/ios/cronet_consumer/BUILD.gn ('k') | components/cronet/ios/cronet_consumer/cronet_consumer_view_controller.m » ('j') | components/cronet/tools/package_ios.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm

diff --git a/components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm b/components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm

index a6c0605fd053fc5829624714c7a2afdc015987f3..4163ee092e07af80c7b48b0a94c7cab2c40d28f6 100644

--- a/components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm

+++ b/components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm

@@ -4,7 +4,7 @@

#import "cronet_consumer_app_delegate.h"

-#import <Cronet/Cronet.h>

+#import "components/cronet/ios/Cronet.h"

kapishnikov 2017/05/17 16:02:49 Ideally, we should not make this change but depend

mef 2017/05/19 18:07:59 Yes, ideally we'll make a static framework, so con

#include "base/format_macros.h"

#import "cronet_consumer_view_controller.h"