[Android O] Initialize channels on first launch/upgrade

chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsUpdaterTest.java

Index: chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsUpdaterTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsUpdaterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsUpdaterTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..2acbdc9aa95c723a165a0b3d1705192a44a16916
--- /dev/null
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsUpdaterTest.java
@@ -0,0 +1,110 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.notifications;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.hamcrest.Matchers.greaterThan;
+import static org.hamcrest.Matchers.is;
+
+import android.app.NotificationManager;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.BlockJUnit4ClassRunner;
+
+import org.chromium.base.test.util.InMemorySharedPreferences;
+import org.chromium.chrome.test.util.browser.notifications.MockNotificationManagerProxy;
+
+/**
+ * Tests that ChannelsUpdater correctly initializes channels on the notification manager.
+ */
+@RunWith(BlockJUnit4ClassRunner.class)
+public class ChannelsUpdaterTest {
+    private MockNotificationManagerProxy mMockNotificationManager;
+    private InMemorySharedPreferences mMockSharedPreferences;
+
+    @Before
+    public void setUp() throws Exception {
+        mMockNotificationManager = new MockNotificationManagerProxy();
+        mMockSharedPreferences = new InMemorySharedPreferences();
+    }
+
+    @Test
+    public void testShouldUpdateChannels_returnsFalsePreO() throws Exception {
+        ChannelsUpdater updater = new ChannelsUpdater(
+                false /* isAtLeastO */, mMockSharedPreferences, mMockNotificationManager, 0);
+        assertThat(updater.shouldUpdateChannels(), is(false));
+    }
+
+    @Test
+    public void testShouldUpdateChannels_returnsTrueIfOAndNoSavedVersionInPrefs() throws Exception {
+        ChannelsUpdater updater = new ChannelsUpdater(
+                true /* isAtLeastO */, mMockSharedPreferences, mMockNotificationManager, 0);
+        assertThat(updater.shouldUpdateChannels(), is(true));
+    }
+
+    @Test
+    public void testShouldUpdateChannels_returnsTrueIfOAndDifferentVersionInPrefs()
+            throws Exception {
+        mMockSharedPreferences.edit().putInt(ChannelsUpdater.CHANNELS_VERSION_KEY, 4).apply();
+        ChannelsUpdater updater = new ChannelsUpdater(
+                true /* isAtLeastO */, mMockSharedPreferences, mMockNotificationManager, 5);
+        assertThat(updater.shouldUpdateChannels(), is(true));
+    }
+
+    @Test
+    public void testShouldUpdateChannels_returnsFalseIfOAndSameVersionInPrefs() throws Exception {
+        mMockSharedPreferences.edit().putInt(ChannelsUpdater.CHANNELS_VERSION_KEY, 3).apply();
+        ChannelsUpdater updater = new ChannelsUpdater(
+                true /* isAtLeastO */, mMockSharedPreferences, mMockNotificationManager, 3);
+        assertThat(updater.shouldUpdateChannels(), is(false));
+    }
+
+    @Test
+    public void testUpdateChannels_noopPreO() throws Exception {
+        ChannelsUpdater updater = new ChannelsUpdater(
+                false /* isAtLeastO */, mMockSharedPreferences, mMockNotificationManager, 21);
+        updater.updateChannels();
+
+        assertThat(mMockNotificationManager.getChannels().size(), is(0));
+        assertThat(mMockSharedPreferences.getInt(ChannelsUpdater.CHANNELS_VERSION_KEY, -1), is(-1));
+    }
+
+    @Test
+    public void testUpdateChannels_createsExpectedChannelsAndUpdatesPref() throws Exception {
+        ChannelsUpdater updater = new ChannelsUpdater(
+                true /* isAtLeastO */, mMockSharedPreferences, mMockNotificationManager, 21);
+        updater.updateChannels();
+
+        assertThat(mMockNotificationManager.getChannels().size(), is(greaterThan(0)));
+        assertThat(mMockNotificationManager.getNotificationChannelIds(),
+                containsInAnyOrder(ChannelsInitializer.CHANNEL_ID_BROWSER,
+                        ChannelsInitializer.CHANNEL_ID_SITES));
+        assertThat(mMockSharedPreferences.getInt(ChannelsUpdater.CHANNELS_VERSION_KEY, -1), is(21));
+    }
+
+    @SuppressWarnings("WrongConstant") // for constructing the old channel with invalid parameters

[nyquist, 2017/04/11 19:03:49]

Nit: Capitalize For and add period.

[awdf, 2017/04/12 13:58:15]

Went one better and turned it into an actual sentence.

+    @Test
+    public void testUpdateChannels_deletesOldChannelsAndCreatesExpectedOnes() throws Exception {
+        mMockNotificationManager.createNotificationChannel(new ChannelsInitializer.Channel(
+                "OldChannel", 8292304, NotificationManager.IMPORTANCE_HIGH,
+                ChannelsInitializer.CHANNEL_GROUP_ID_GENERAL));
+        mMockNotificationManager.createNotificationChannel(
+                new ChannelsInitializer.Channel("AnotherOldChannel", 8292304,
+                        NotificationManager.IMPORTANCE_LOW, "OldChannelGroup"));
+        assertThat(mMockNotificationManager.getNotificationChannelIds(),
+                containsInAnyOrder("OldChannel", "AnotherOldChannel"));
+
+        ChannelsUpdater updater = new ChannelsUpdater(
+                true /* isAtLeastO */, mMockSharedPreferences, mMockNotificationManager, 12);
+        updater.updateChannels();
+
+        assertThat(mMockNotificationManager.getNotificationChannelIds(),
+                containsInAnyOrder(ChannelsInitializer.CHANNEL_ID_BROWSER,
+                        ChannelsInitializer.CHANNEL_ID_SITES));
+    }
+}