Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8712)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java

Issue 2807213002: [Android O] Initialize channels on first launch/upgrade (Closed)
Patch Set: Initialize channels on first launch and upgrade Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java b/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java
index 3b8782df95d4f7265d87a6d5fcf2a0923e4ff121..7b3d6b5c92c597cb2d3be100d7f7ae554e2b2c7f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java
@@ -9,6 +9,8 @@ import android.content.Context;
import android.content.Intent;
import android.os.Build;
+import org.chromium.chrome.browser.notifications.ChannelsUpdater;
+
/**
* Triggered when Chrome's package is replaced (e.g. when it is upgraded).
*
@@ -27,6 +29,9 @@ public final class PackageReplacedBroadcastReceiver extends BroadcastReceiver {
@Override
public void onReceive(Context context, Intent intent) {
if (!Intent.ACTION_MY_PACKAGE_REPLACED.equals(intent.getAction())) return;
+ if (ChannelsUpdater.shouldUpdateChannels()) {
nyquist 2017/04/10 21:04:30 Do we want ChannelsUpdate.updateChannelsIfNecessar
awdf 2017/04/11 14:19:22 This isn't applicable now that I've added the asyn
+ ChannelsUpdater.updateChannels(context);
nyquist 2017/04/10 21:04:30 I think this might end up writing to disk? Do we w
awdf 2017/04/11 14:19:21 Ah cool I didn't know about that one - sounds like
+ }
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.N) return;
UpgradeIntentService.startMigrationIfNecessary(context);
}

Powered by Google App Engine
This is Rietveld 408576698