Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: src/builtins/builtins-regexp-gen.h

Issue 2807153002: [regexp] Avoid side effects between map load and fast path check (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-regexp-gen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 the V8 project authors. All rights reserved. 1 // Copyright 2017 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_BUILTINS_BUILTINS_REGEXP_H_ 5 #ifndef V8_BUILTINS_BUILTINS_REGEXP_H_
6 #define V8_BUILTINS_BUILTINS_REGEXP_H_ 6 #define V8_BUILTINS_BUILTINS_REGEXP_H_
7 7
8 #include "src/code-stub-assembler.h" 8 #include "src/code-stub-assembler.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 const bool is_fastpath); 52 const bool is_fastpath);
53 Node* RegExpPrototypeExecBody(Node* const context, Node* const regexp, 53 Node* RegExpPrototypeExecBody(Node* const context, Node* const regexp,
54 Node* const string, const bool is_fastpath); 54 Node* const string, const bool is_fastpath);
55 55
56 Node* ThrowIfNotJSReceiver(Node* context, Node* maybe_receiver, 56 Node* ThrowIfNotJSReceiver(Node* context, Node* maybe_receiver,
57 MessageTemplate::Template msg_template, 57 MessageTemplate::Template msg_template,
58 char const* method_name); 58 char const* method_name);
59 59
60 // Analogous to BranchIfFastRegExp, for use in asserts. 60 // Analogous to BranchIfFastRegExp, for use in asserts.
61 Node* IsFastRegExp(Node* const context, Node* const object); 61 Node* IsFastRegExp(Node* const context, Node* const object);
62 Node* IsFastRegExp(Node* const context, Node* const object, Node* const map);
63 62
64 // Performs fast path checks on the given object itself, but omits prototype 63 // Performs fast path checks on the given object itself, but omits prototype
65 // checks. 64 // checks.
66 Node* IsFastRegExpNoPrototype(Node* const context, Node* const object, 65 Node* IsFastRegExpNoPrototype(Node* const context, Node* const object,
67 Node* const map); 66 Node* const map);
68 67
69 void BranchIfFastRegExpResult(Node* context, Node* map, 68 void BranchIfFastRegExpResult(Node* context, Node* map,
70 Label* if_isunmodified, Label* if_ismodified); 69 Label* if_isunmodified, Label* if_ismodified);
71 70
72 Node* FlagsGetter(Node* const context, Node* const regexp, bool is_fastpath); 71 Node* FlagsGetter(Node* const context, Node* const regexp, bool is_fastpath);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 Node* ReplaceGlobalCallableFastPath(Node* context, Node* regexp, Node* string, 104 Node* ReplaceGlobalCallableFastPath(Node* context, Node* regexp, Node* string,
106 Node* replace_callable); 105 Node* replace_callable);
107 Node* ReplaceSimpleStringFastPath(Node* context, Node* regexp, Node* string, 106 Node* ReplaceSimpleStringFastPath(Node* context, Node* regexp, Node* string,
108 Node* replace_string); 107 Node* replace_string);
109 }; 108 };
110 109
111 } // namespace internal 110 } // namespace internal
112 } // namespace v8 111 } // namespace v8
113 112
114 #endif // V8_BUILTINS_BUILTINS_REGEXP_H_ 113 #endif // V8_BUILTINS_BUILTINS_REGEXP_H_
OLDNEW
« no previous file with comments | « no previous file | src/builtins/builtins-regexp-gen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698