Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: third_party/WebKit/Source/core/input/MouseEventManager.h

Issue 2807123002: Fix the wrong non-element node handling in EventHanlder and MouseEventManager (Closed)
Patch Set: Addressed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/MouseEventManager.h
diff --git a/third_party/WebKit/Source/core/input/MouseEventManager.h b/third_party/WebKit/Source/core/input/MouseEventManager.h
index 2ac5c782d82fa03548bbaaeca7d76753ac43833b..9bebf63370320a074b44131ab70c284fc80939a8 100644
--- a/third_party/WebKit/Source/core/input/MouseEventManager.h
+++ b/third_party/WebKit/Source/core/input/MouseEventManager.h
@@ -58,7 +58,7 @@ class CORE_EXPORT MouseEventManager final
WebInputEventResult DispatchMouseClickIfNeeded(
const MouseEventWithHitTestResults&,
- Node* release_node);
+ Element& mouse_release_target);
WebInputEventResult DispatchDragSrcEvent(const AtomicString& event_type,
const WebMouseEvent&);
@@ -139,7 +139,7 @@ class CORE_EXPORT MouseEventManager final
Node* MousePressNode();
void SetMousePressNode(Node*);
- void SetClickNode(Node*);
+ void SetClickElement(Element*);
void SetClickCount(int);
bool MouseDownMayStartDrag();
@@ -225,7 +225,7 @@ class CORE_EXPORT MouseEventManager final
Member<Node> mouse_press_node_;
int click_count_;
- Member<Node> click_node_;
+ Member<Element> click_element_;
IntPoint mouse_down_pos_; // In our view's coords.
TimeTicks mouse_down_timestamp_;

Powered by Google App Engine
This is Rietveld 408576698