third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp - Issue 2807073002: Removed local RefPtr objects created from PassRefPtr arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

Issue 2807073002: Removed local RefPtr objects created from PassRefPtr arguments. (Closed)

Patch Set: addressed review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.h ('k') | third_party/WebKit/Source/platform/network/NetworkStateNotifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

diff --git a/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp b/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

index 06d0234b67c6af8bcbd42bf367d70bd62bff85d5..b54e1f57895dbb7463e47a84fbe90940319a9a10 100644

--- a/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

+++ b/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp

@@ -472,7 +472,7 @@ void CrossOriginAccessControl::RedirectErrorString(

}

bool CrossOriginAccessControl::HandleRedirect(

- PassRefPtr<SecurityOrigin> security_origin,

+ RefPtr<SecurityOrigin> current_security_origin,

ResourceRequest& new_request,

const ResourceResponse& redirect_response,

StoredCredentials with_credentials,

@@ -482,8 +482,6 @@ bool CrossOriginAccessControl::HandleRedirect(

const KURL& last_url = redirect_response.Url();

const KURL& new_url = new_request.Url();

- RefPtr<SecurityOrigin> current_security_origin = security_origin;

RefPtr<SecurityOrigin> new_security_origin = current_security_origin;

// TODO(tyoshino): This should be fixed to check not only the last one but