Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

Issue 2807073002: Removed local RefPtr objects created from PassRefPtr arguments. (Closed)
Patch Set: addressed review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
index ee18215c6a5508cb28942880a92426051856abd1..5f85965b7bb9676c31f74975ab31c772efe9038a 100644
--- a/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
@@ -428,7 +428,7 @@ DEFINE_TRACE(WorkerThreadableLoader) {
void WorkerThreadableLoader::MainThreadLoaderHolder::CreateAndStart(
WorkerThreadableLoader* worker_loader,
- PassRefPtr<WorkerLoaderProxy> pass_loader_proxy,
+ RefPtr<WorkerLoaderProxy> loader_proxy,
WorkerThreadLifecycleContext* worker_thread_lifecycle_context,
std::unique_ptr<CrossThreadResourceRequestData> request,
const ThreadableLoaderOptions& options,
@@ -436,7 +436,6 @@ void WorkerThreadableLoader::MainThreadLoaderHolder::CreateAndStart(
PassRefPtr<WaitableEventWithTasks> event_with_tasks) {
DCHECK(IsMainThread());
TaskForwarder* forwarder;
- RefPtr<WorkerLoaderProxy> loader_proxy = pass_loader_proxy;
ThreadableLoadingContext* loading_context =
loader_proxy->GetThreadableLoadingContext();
if (!loading_context)
@@ -444,7 +443,7 @@ void WorkerThreadableLoader::MainThreadLoaderHolder::CreateAndStart(
if (event_with_tasks)
forwarder = new SyncTaskForwarder(std::move(event_with_tasks));
else
- forwarder = new AsyncTaskForwarder(loader_proxy);
+ forwarder = new AsyncTaskForwarder(std::move(loader_proxy));
MainThreadLoaderHolder* main_thread_loader_holder =
new MainThreadLoaderHolder(forwarder, worker_thread_lifecycle_context);

Powered by Google App Engine
This is Rietveld 408576698