Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2166)

Unified Diff: base/task_scheduler/task_scheduler_impl.cc

Issue 2807063007: Remove SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_scheduler_impl.cc
diff --git a/base/task_scheduler/task_scheduler_impl.cc b/base/task_scheduler/task_scheduler_impl.cc
index 01786493748a967f9901b206245d2bb5879f05c0..b31f6061a40be529141c421031340ec0950314d5 100644
--- a/base/task_scheduler/task_scheduler_impl.cc
+++ b/base/task_scheduler/task_scheduler_impl.cc
@@ -6,8 +6,6 @@
#include <utility>
-#include "base/bind.h"
-#include "base/bind_helpers.h"
#include "base/memory/ptr_util.h"
#include "base/task_scheduler/delayed_task_manager.h"
#include "base/task_scheduler/scheduler_single_thread_task_runner_manager.h"
@@ -196,12 +194,6 @@ void TaskSchedulerImpl::Initialize(
task_tracker_.get(), delayed_task_manager_.get());
single_thread_task_runner_manager_->Start();
- // Callback invoked by workers to re-enqueue a sequence in the appropriate
- // PriorityQueue.
- const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback
- re_enqueue_sequence_callback =
- Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this));
-
// Order must match the EnvironmentType enum.
const SchedulerWorkerPoolParams* worker_pool_params[] = {
&init_params.background_worker_pool_params,
@@ -226,8 +218,7 @@ void TaskSchedulerImpl::Initialize(
// deleted before all its worker pools have been joined.
worker_pools_[environment_type] = MakeUnique<SchedulerWorkerPoolImpl>(
name_ + kEnvironmentParams[environment_type].name_suffix,
- kEnvironmentParams[environment_type].priority_hint,
- re_enqueue_sequence_callback, task_tracker_.get(),
+ kEnvironmentParams[environment_type].priority_hint, task_tracker_.get(),
delayed_task_manager_.get());
worker_pools_[environment_type]->Start(
*worker_pool_params[environment_type]);
@@ -239,21 +230,5 @@ SchedulerWorkerPoolImpl* TaskSchedulerImpl::GetWorkerPoolForTraits(
return worker_pools_[GetEnvironmentIndexForTraits(traits)].get();
}
-void TaskSchedulerImpl::ReEnqueueSequenceCallback(
- scoped_refptr<Sequence> sequence) {
- DCHECK(sequence);
-
- const SequenceSortKey sort_key = sequence->GetSortKey();
-
- // The next task in |sequence| should run in a worker pool suited for its
- // traits, except for the priority which is adjusted to the highest priority
- // in |sequence|.
- const TaskTraits traits =
- sequence->PeekTaskTraits().WithPriority(sort_key.priority());
-
- GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence),
- sort_key);
-}
-
} // namespace internal
} // namespace base
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698