Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.h

Issue 2807063007: Remove SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool.h ('k') | base/task_scheduler/scheduler_worker_pool_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_pool_impl.h
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.h b/base/task_scheduler/scheduler_worker_pool_impl.h
index 7b285a54d38a84d6380f97bc19e4945f414cae9d..8a0e98850d7e82e81141aa123f5944e9510bcb37 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.h
+++ b/base/task_scheduler/scheduler_worker_pool_impl.h
@@ -12,7 +12,6 @@
#include <vector>
#include "base/base_export.h"
-#include "base/callback.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
@@ -41,10 +40,6 @@ class TaskTracker;
// A pool of workers that run Tasks. This class is thread-safe.
class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {
public:
- // Callback invoked when a Sequence isn't empty after a worker pops a Task
- // from it.
- using ReEnqueueSequenceCallback = Callback<void(scoped_refptr<Sequence>)>;
-
// Constructs a pool without workers. Tasks can be posted to the pool, but
// they won't run until workers are created. To create workers and start
// running tasks, call Start().
@@ -53,13 +48,11 @@ class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {
// index) and histograms ("TaskScheduler." + histogram name + "." + |name| +
// extra suffixes). |priority_hint| is the preferred thread priority; the
// actual thread priority depends on shutdown state and platform capabilities.
- // |re_enqueue_sequence_callback| is invoked when a Sequence isn't empty after
- // a worker pops a Task from it. |task_tracker| keeps track of tasks.
- // |delayed_task_manager| handles tasks posted with a delay.
+ // |task_tracker| keeps track of tasks. |delayed_task_manager| handles tasks
+ // posted with a delay.
SchedulerWorkerPoolImpl(
const std::string& name,
ThreadPriority priority_hint,
- ReEnqueueSequenceCallback re_enqueue_sequence_callback,
TaskTracker* task_tracker,
DelayedTaskManager* delayed_task_manager);
@@ -77,8 +70,6 @@ class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {
const TaskTraits& traits) override;
scoped_refptr<SequencedTaskRunner> CreateSequencedTaskRunnerWithTraits(
const TaskTraits& traits) override;
- void ReEnqueueSequence(scoped_refptr<Sequence> sequence,
- const SequenceSortKey& sequence_sort_key) override;
bool PostTaskWithSequence(std::unique_ptr<Task> task,
scoped_refptr<Sequence> sequence) override;
void PostTaskWithSequenceNow(std::unique_ptr<Task> task,
@@ -140,7 +131,6 @@ class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {
const std::string name_;
const ThreadPriority priority_hint_;
- const ReEnqueueSequenceCallback re_enqueue_sequence_callback_;
// PriorityQueue from which all threads of this worker pool get work.
PriorityQueue shared_priority_queue_;
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool.h ('k') | base/task_scheduler/scheduler_worker_pool_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698