Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: ui/file_manager/zip_archiver/cpp/volume_reader_javascript_stream.h

Issue 2807063002: Replace Libarchive with MiniZip. (Closed)
Patch Set: Delete BUILD.gn Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/zip_archiver/cpp/volume_reader_javascript_stream.h
diff --git a/ui/file_manager/zip_archiver/cpp/volume_reader_javascript_stream.h b/ui/file_manager/zip_archiver/cpp/volume_reader_javascript_stream.h
index 54b68953debc16aaf6ede8c770d95eceadae2ea4..b589c7b72e42b58c1d302f54268f9d3d0ae0797c 100644
--- a/ui/file_manager/zip_archiver/cpp/volume_reader_javascript_stream.h
+++ b/ui/file_manager/zip_archiver/cpp/volume_reader_javascript_stream.h
@@ -7,7 +7,6 @@
#include <pthread.h>
-#include "archive.h"
#include "ppapi/cpp/var_array_buffer.h"
#include "javascript_requestor_interface.h"
@@ -60,9 +59,6 @@ class VolumeReaderJavaScriptStream : public VolumeReader {
virtual int64_t Read(int64_t bytes_to_read, const void** destination_buffer);
// See volume_reader.h for description.
- virtual int64_t Skip(int64_t bytes_to_skip);
-
- // See volume_reader.h for description.
virtual int64_t Seek(int64_t offset, int whence);
// Sets the request Id to be used by the reader.
@@ -73,16 +69,18 @@ class VolumeReaderJavaScriptStream : public VolumeReader {
// another thread.
virtual const char* Passphrase();
- int64_t offset() const { return offset_; }
+ virtual int64_t offset();
mtomasz 2017/04/10 07:15:09 nit: Why is this moved to .cc?
takise 2017/04/11 06:00:52 Done.
+
+ int64_t archive_size() { return archive_size_; }
private:
// Request a chunk of length number of bytes from JavaScript starting from
// offset_ member. Should be run within a lock.
void RequestChunk(int64_t length);
- std::string request_id_; // The request id for which the reader was
- // created.
- const int64_t archive_size_; // The archive size.
+ std::string request_id_; // The request id for which the reader was
+ // created.
+ const int64_t archive_size_; // The archive size.
// A requestor that makes calls to JavaScript to obtain file chunks.
JavaScriptRequestorInterface* requestor_;

Powered by Google App Engine
This is Rietveld 408576698