[Isolates] RegExpStack and memory allocation limits (statics #6)

[Isolates] RegExpStack and memory allocation limits 

regexp-stack: 
-> Split RegExpStackState from RegExpStack. RegExpStacks can be allocated 
at will, while there is only one RegExpStackState per isolate. 

platform-linux/platform-macos: 
-> Protect lowest_ever_allocated and highest_ever_allocated with 
a mutex (limit_mutex) that is initialized in OS::Setup.



Committed: http://code.google.com/p/v8/source/detail?r=5003

[zarko, 2010-06-29 23:44:42]

This could be the last of the obvious CLs.

Thanks
  Luke

[Vitaly Repeshko, 2010-07-01 20:53:23]

What about adding a similar mutex to platform-win32?

http://codereview.chromium.org/2807031/diff/16001/17010
File src/regexp-stack.h (right):

http://codereview.chromium.org/2807031/diff/16001/17010#newcode41
src/regexp-stack.h:41: class RegExpStack {
The usage pattern of these two classes suggests other naming: RegExpStackScope
and RegExpStack.

http://codereview.chromium.org/2807031/diff/16001/17010#newcode48
src/regexp-stack.h:48: 
It might make sense to expose an accessor to the current stack. Then we can
write code like this:
RegExpStackScope re_scope(isolate);
Foo(re_scope.stack()->stack_base())

http://codereview.chromium.org/2807031/diff/16001/17010#newcode51
src/regexp-stack.h:51: };
DISALLOW_COPY_AND_ASSIGN

[zarko, 2010-07-01 21:19:16]

On 2010/07/01 20:53:23, Vitaly wrote:
> What about adding a similar mutex to platform-win32?
> 
> http://codereview.chromium.org/2807031/diff/16001/17010
> File src/regexp-stack.h (right):
> 
> http://codereview.chromium.org/2807031/diff/16001/17010#newcode41
> src/regexp-stack.h:41: class RegExpStack {
> The usage pattern of these two classes suggests other naming: RegExpStackScope
> and RegExpStack.
> 
> http://codereview.chromium.org/2807031/diff/16001/17010#newcode48
> src/regexp-stack.h:48: 
> It might make sense to expose an accessor to the current stack. Then we can
> write code like this:
> RegExpStackScope re_scope(isolate);
> Foo(re_scope.stack()->stack_base())
> 
> http://codereview.chromium.org/2807031/diff/16001/17010#newcode51
> src/regexp-stack.h:51: };
> DISALLOW_COPY_AND_ASSIGN

I think I hit these; thanks for the feedback!

[Vitaly Repeshko, 2010-07-01 21:39:00]

LGTM.