Issue 280703010: [Telemetry] Speed up page_cycler on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 280703010: [Telemetry] Speed up page_cycler on android. (Closed)

Created:
6 years, 7 months ago by bulach

Modified:
6 years, 7 months ago

Reviewers:
tonyg

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Speed up page_cycler on android. Down to 3m22 (without the other optimizations..) /proc/pid/smaps is kind of large. It was only used by old style perf tests downstream, long gone in favor of Telemetry. Use "showmap %pid" directly, which crunches the data in the device. Also, while at it, remove GetMemoryUsageForPackage: no longer used. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270395

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -56 lines)			Patch
	M	build/android/pylib/android_commands.py	View	1	2 chunks	+20 lines, -55 lines	0 comments	Download
	M	tools/telemetry/telemetry/core/platform/android_platform_backend.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bulach

ptal :) (it won't apply cleanly, need to be rebased after https://codereview.chromium.org/278763005/).

6 years, 7 months ago (2014-05-13 16:21:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/280703010/20001

6 years, 7 months ago (2014-05-14 09:45:18 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-14 12:09:47 UTC) #5

Message was sent while issue was closed.

Change committed as 270395

Expand Messages | Collapse Messages