sync: Move NonBlockingTypeProcessor to sync/engine

sync: Move NonBlockingTypeProcessor to sync/engine

Moves NonBlockingTypeProcessor from sync/internal_api to sync/engine.

It's become increasingly clear to me that the NonBlockingTypeProcessor
will be too big to expose outside of sync.  When it comes time to export
its functionality, we'll need to define a wrapper class with a simpler
interface.  This means that there's no benefit to keeping it in
internal_api.

There is a benefit to moving this to sync/engine.  In this location, it
should be able to collaborate more closely with its sibling, the
NonBlockingTypeProcessorCore.

We intend to start adding lots of code to this class soon.  It's a good
idea to get this move out of the way first, so we can have a better git
history in the end.

BUG=351005
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270025

[rlarocque, 2014-05-12 23:46:10]

I'd like to land this change before we move on to implementing some of the TODOs
in NonBlockingTypeProcessor.

I won't be able to commit this today, since it will have to be rebased once
https://codereview.chromium.org/272323002/.

Please review.

[Nicolas Zea, 2014-05-12 23:52:06]

lgtm

https://codereview.chromium.org/280693003/diff/20001/sync/engine/DEPS
File sync/engine/DEPS (right):

https://codereview.chromium.org/280693003/diff/20001/sync/engine/DEPS#newcode4
sync/engine/DEPS:4: "+sync/internal_api/public/base",
I think all these subdirs can be removed now right?

[rlarocque, 2014-05-13 00:06:19]

The patch I was waiting for landed two minutes after I sent this review request.
 It looks like I will be able to commit this today.

https://codereview.chromium.org/280693003/diff/20001/sync/engine/DEPS
File sync/engine/DEPS (right):

https://codereview.chromium.org/280693003/diff/20001/sync/engine/DEPS#newcode4
sync/engine/DEPS:4: "+sync/internal_api/public/base",
On 2014/05/12 23:52:06, Nicolas Zea wrote:
> I think all these subdirs can be removed now right?

Done.

[rlarocque, 2014-05-13 00:06:45]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-05-13 00:08:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/280693003/40001

[commit-bot: I haz the power, 2014-05-13 05:10:30]

Change committed as 270025