Don't create parallel request if download is about to complete

content/browser/download/parallel_download_job.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/parallel_download_job.h"
 
+#include <algorithm>
+
 #include "base/memory/ptr_util.h"
+#include "base/metrics/histogram_macros.h"
+#include "base/time/time.h"
 #include "content/browser/download/download_create_info.h"
 #include "content/browser/download/download_stats.h"
 #include "content/browser/download/parallel_download_utils.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/storage_partition.h"
 
 namespace content {
 namespace {
 
 const int kVerboseLevel = 1;
@@ skipping 55 matching lines @@
     return;
   }
 
   for (auto& worker : workers_)
     worker.second->Resume();
 }
 
 int ParallelDownloadJob::GetParallelRequestCount() const {
   return GetParallelRequestCountConfig();
 }
+
 int64_t ParallelDownloadJob::GetMinSliceSize() const {
   return GetMinSliceSizeConfig();
 }
 
+int ParallelDownloadJob::GetMinRemainingTimeInSeconds() const {
+  return GetParallelRequestRemainingTimeConfig().InSeconds();
+}
+
 bool ParallelDownloadJob::UsesParallelRequests() const {
   return true;
 }
 
 void ParallelDownloadJob::BuildParallelRequestAfterDelay() {
   DCHECK(workers_.empty());
   DCHECK(!requests_sent_);
   DCHECK(!timer_.IsRunning());
 
   timer_.Start(FROM_HERE, GetParallelRequestDelayConfig(), this,
@@ skipping 45 matching lines @@
   // of the workers finish their job.
   DownloadItem::ReceivedSlices slices_to_download =
       FindSlicesToDownload(download_item_->GetReceivedSlices());
 
   DCHECK(!slices_to_download.empty());
   int64_t first_slice_offset = slices_to_download[0].offset;
   DCHECK_LE(initial_request_offset_, first_slice_offset);
 
   // Create more slices for a new download. The initial request may generate
   // a received slice.
-  if (slices_to_download.size() <= 1 &&
-      initial_request_offset_ <= first_slice_offset) {
-    // TODO(qinmin): Check the size of the last slice. If it is huge, we can
-    // split it into N pieces and pass the last N-1 pieces to different workers.
-    // Otherwise, just fork |slices_to_download.size()| number of workers.
-    slices_to_download = FindSlicesForRemainingContent(
-        first_slice_offset,
-        content_length_ - first_slice_offset + initial_request_offset_,
-        GetParallelRequestCount(), GetMinSliceSize());
+  if (slices_to_download.size() <= 1 && download_item_->GetTotalBytes() > 0) {
+    int64_t current_bytes_per_second =
+        std::max(static_cast<int64_t>(1), download_item_->CurrentSpeed());
+    int64_t remaining_bytes =
+        download_item_->GetTotalBytes() - download_item_->GetReceivedBytes();
+
+    int64_t remaining_time = remaining_bytes / current_bytes_per_second;
+    UMA_HISTOGRAM_CUSTOM_COUNTS(
+        "Download.ParallelDownload.RemainingTimeWhenBuildingRequests",
+        remaining_time, 0, base::TimeDelta::FromDays(1).InSeconds(), 50);
+    if (remaining_bytes / current_bytes_per_second >
+        GetMinRemainingTimeInSeconds()) {
+      // TODO(qinmin): Check the size of the last slice. If it is huge, we can
+      // split it into N pieces and pass the last N-1 pieces to different
+      // workers. Otherwise, just fork |slices_to_download.size()| number of
+      // workers.
+      slices_to_download = FindSlicesForRemainingContent(
+          first_slice_offset,
+          content_length_ - first_slice_offset + initial_request_offset_,
+          GetParallelRequestCount(), GetMinSliceSize());
+    } else {
+      RecordParallelDownloadCreationEvent(
+          ParallelDownloadCreationEvent::FALLBACK_REASON_REMAINING_TIME);
+    }
   }
 
   DCHECK(!slices_to_download.empty());
   DCHECK_EQ(slices_to_download.back().received_bytes,
             DownloadSaveInfo::kLengthFullContent);
 
   ForkSubRequests(slices_to_download);
   RecordParallelDownloadRequestCount(
       static_cast<int>(slices_to_download.size()));
   requests_sent_ = true;
@@ skipping 41 matching lines @@
   // download request.
   download_params->set_referrer(Referrer(download_item_->GetReferrerUrl(),
                                          blink::kWebReferrerPolicyAlways));
   // Send the request.
   worker->SendRequest(std::move(download_params));
   DCHECK(workers_.find(offset) == workers_.end());
   workers_[offset] = std::move(worker);
 }
 
 }  // namespace content