Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2806893002: Make finalization of recursive function types more robust, especially since (Closed)

Created:
3 years, 8 months ago by regis
Modified:
3 years, 8 months ago
Reviewers:
ahe, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make finalization of recursive function types more robust, especially since the Kernel frontend may omit the information that a function type is a typedef. Re-enable several previously failing tests for dartk. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/8ca244ba27f85b9bc5b2b01daacf020f398ac58a

Patch Set 1 #

Patch Set 2 : updated tests status and sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -70 lines) Patch
M runtime/vm/class_finalizer.cc View 3 chunks +53 lines, -59 lines 0 comments Download
M runtime/vm/object.cc View 1 3 chunks +13 lines, -4 lines 0 comments Download
M tests/language/language_kernel.status View 1 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
regis
3 years, 8 months ago (2017-04-07 22:51:01 UTC) #2
siva
lgtm
3 years, 8 months ago (2017-04-10 17:58:52 UTC) #4
regis
3 years, 8 months ago (2017-04-10 18:06:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8ca244ba27f85b9bc5b2b01daacf020f398ac58a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698