Fixing testBrowsingPostEntryWithButton flakiness.

ios/chrome/test/earl_grey/chrome_earl_grey.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
 
 #import <Foundation/Foundation.h>
 #import <WebKit/WebKit.h>
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #import "base/test/ios/wait_util.h"
 #include "components/strings/grit/components_strings.h"
 #import "ios/chrome/browser/ui/static_content/static_html_view_controller.h"
 #import "ios/chrome/test/app/chrome_test_util.h"
 #import "ios/chrome/test/app/history_test_util.h"
 #include "ios/chrome/test/app/navigation_test_util.h"
 #import "ios/chrome/test/app/static_html_view_test_util.h"
+#import "ios/chrome/test/earl_grey/chrome_matchers.h"
 #import "ios/testing/wait_util.h"
 #import "ios/web/public/test/earl_grey/js_test_util.h"
 #import "ios/web/public/test/web_view_interaction_test_util.h"
 #import "ios/web/public/web_state/js/crw_js_injection_receiver.h"
 #import "ios/web/public/web_state/web_state.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
@@ skipping 124 matching lines @@
       conditionWithName:@"Wait for absence of static HTML text."
                   block:^BOOL {
                     return !chrome_test_util::StaticHtmlViewContainingText(
                         chrome_test_util::GetCurrentWebState(),
                         base::SysNSStringToUTF8(text));
                   }];
   GREYAssert([condition waitWithTimeout:testing::kWaitForUIElementTimeout],
              @"Failed, there was a static html view containing %@", text);
 }
 
++ (void)waitForOmniboxText:(NSString*)text {
+  GREYCondition* condition = [GREYCondition
+      conditionWithName:@"Wait for omnibox text."
+                  block:^BOOL {
+                    NSError* error = nil;
+                    [[EarlGrey
+                        selectElementWithMatcher:chrome_test_util::OmniboxText(
+                                                     base::SysNSStringToUTF8(
+                                                         text))]

[gchatz, 2017/04/08 00:17:05]

Could the matcher be made a local variable to have better formatting?

[Eugene But (OOO till 7-30), 2017/04/08 00:20:36]

Using functions for matchers instead of local variables looks cleaner and it is
more reusable. In this case changing argument to std::string and adding |using
chrome_test_util::OmniboxText| would solve the formatting problem. But do we
even need |waitForOmniboxText:| API? Can we wait for web view text instead?

[liaoyuke, 2017/04/08 00:43:07]

replied in another comment, will make the change if we decide that
|waitForOmniboxText:| is needed.

+                        assertWithMatcher:grey_notNil()
+                                    error:&error];
+                    return error == nil;
+                  }];
+  GREYAssert([condition waitWithTimeout:testing::kWaitForUIElementTimeout],
+             @"Failed, omnibox was not %@", text);
+}
+
 @end