third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp - Issue 2806683002: Don't ever split DocumentMarkers on remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp

Issue 2806683002: Don't ever split DocumentMarkers on remove (Closed)

Patch Set: Leave partial markers in place for non-splitting case, preserve endpoints for splitting case Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('K') | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp b/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp

index 200ddca112b3bfff9e7191ec26d80629c307e6c0..79fd0e77e370493d068781e48a02fcf48eb66956 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp

@@ -108,8 +108,7 @@ void HotModeSpellCheckRequester::checkSpellingAt(const Position& position) {

currentWordIfTypingInPartialWord(*rootEditable);

if (currentWord.isNotNull()) {

rootEditable->document().markers().removeMarkers(

- currentWord, DocumentMarker::MisspellingMarkers(),

- DocumentMarkerController::RemovePartiallyOverlappingMarker);

+ currentWord, DocumentMarker::MisspellingMarkers());

return;

}