third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp - Issue 2806683002: Don't ever split DocumentMarkers on remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 2806683002: Don't ever split DocumentMarkers on remove (Closed)

Patch Set: Leave partial markers in place for non-splitting case, preserve endpoints for splitting case Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h » ('j') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

index 9e71df2eebcecb00169d30a24922c2cf61cb16ac..49f1e041d37dda757deb5819b6e76283aa62ae01 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

@@ -1870,12 +1870,10 @@ TEST_F(InputMethodControllerTest, Marker_DeleteMiddleOfMarker) {

controller().setCompositionFromExistingText(emptyUnderlines, 6, 9);

controller().commitText(String(""), emptyUnderlines, 0);

- EXPECT_EQ(2u, document().markers().markers().size());

+ EXPECT_EQ(1u, document().markers().markers().size());

EXPECT_EQ(5u, document().markers().markers()[0]->startOffset());

- EXPECT_EQ(6u, document().markers().markers()[0]->endOffset());

- EXPECT_EQ(6u, document().markers().markers()[1]->startOffset());

- EXPECT_EQ(7u, document().markers().markers()[1]->endOffset());

+ EXPECT_EQ(7u, document().markers().markers()[0]->endOffset());

}

TEST_F(InputMethodControllerTest, Marker_InsertInMarkerInterior) {