Chromium Code Reviews Chromium Code Reviews
Issue 2806653002:
Add UMA to track why a download is non-parallel when enabled parallel (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 790748cfab6013c941832b528f865b61ac5721bc..f5b80cc6d7d8b265d82c6347b1becfc33c5d9d25 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -13856,6 +13856,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Download.ParallelDownload.CreationEvent" |
| + enum="ParallelDownloadCreationEvent"> |
| + <owner>xingliu@chromium.org</owner> |
| + <summary> |
| + When parallel downloading feature is enabled, a download may be created as |
| + parallel download or fall back to normal download based on various factor. |
|
Ilya Sherman
2017/04/08 01:22:47
nit: s/factor/factors
xingliu
2017/04/10 18:56:30
Done.
|
| + Records the total number of parallel and non-parallel download creation when |
|
Ilya Sherman
2017/04/08 01:22:47
nit: s/download creation/downloads created
xingliu
2017/04/10 18:56:30
Done.
|
| + parallel downloading feature is enabled. Also records the reason why a |
| + parallel download falls back to normal download. The reasons are not mutual |
|
Ilya Sherman
2017/04/08 01:22:47
nit: s/mutual/mutually
xingliu
2017/04/10 18:56:30
Done.
|
| + exclusive. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Download.ParallelDownloadAddStreamSuccess" |
| enum="BooleanSuccess"> |
| <owner>xingliu@chromium.org</owner> |
| @@ -105714,6 +105727,16 @@ from previous Chrome versions. |
| <int value="1" label="HRTF"/> |
| </enum> |
| +<enum name="ParallelDownloadCreationEvent" type="int"> |
| + <int value="0" label="Parallel download count"/> |
| + <int value="1" label="Fallback to normal download count"/> |
|
Ilya Sherman
2017/04/08 01:22:47
Optional nit: Again, I'd drop "count" from both of
xingliu
2017/04/10 18:56:30
Done.
|
| + <int value="2" label="No strong validators response headers"/> |
| + <int value="3" label="No accept range header"/> |
| + <int value="4" label="No content length header"/> |
| + <int value="5" label="File size does not meet the requirement."/> |
| + <int value="6" label="HTTP connection type mismatch."/> |
| +</enum> |
| + |
| <enum name="ParsedCookieStatus" type="int"> |
| <obsolete> |
| Deprecated as of 9/2013. Experiment to measure control characters in cookies |
