Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp

Issue 2806623004: Worker: Introduce per-global-scope task scheduler (Closed)
Patch Set: remove unnecessary comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
index 631b8afe68957805afd28043d8c512aef81e5822..fffaf55c94f4f9a1c7765a948ad30b20d51e8490 100644
--- a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
@@ -36,6 +36,7 @@
#include "bindings/core/v8/V8GCController.h"
#include "core/dom/Document.h"
#include "core/dom/ExecutionContext.h"
+#include "core/dom/TaskRunnerHelper.h"
#include "core/events/MessageEvent.h"
#include "core/inspector/ConsoleMessage.h"
#include "core/workers/InProcessWorkerMessagingProxy.h"
@@ -121,8 +122,12 @@ void InProcessWorkerObjectProxy::DidCreateWorkerGlobalScope(
WorkerOrWorkletGlobalScope* global_scope) {
DCHECK(!worker_global_scope_);
worker_global_scope_ = ToWorkerGlobalScope(global_scope);
+ // This timer task should be unthrottled in order to prevent GC timing from
+ // being delayed.
+ // TODO(nhiroki): Consider making a special task type for GC.
+ // (https://crbug.com/712504)
timer_ = WTF::MakeUnique<TaskRunnerTimer<InProcessWorkerObjectProxy>>(
- Platform::Current()->CurrentThread()->GetWebTaskRunner(), this,
+ TaskRunnerHelper::Get(TaskType::kUnthrottled, global_scope), this,
&InProcessWorkerObjectProxy::CheckPendingActivity);
}

Powered by Google App Engine
This is Rietveld 408576698