Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 2806613002: Check IME state in ImeController (Closed)
Patch Set: Add comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index 87eafaca02864b1b556f87c807bb133995a9c5f0..88d16ef4ee0feb8058981c959469450cbad1f7c4 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -90,6 +90,7 @@
#include "chrome/browser/chromeos/ui/low_disk_notification.h"
#include "chrome/browser/chromeos/upgrade_detector_chromeos.h"
#include "chrome/browser/defaults.h"
+#include "chrome/browser/extensions/extension_error_reporter.h"
#include "chrome/browser/lifetime/application_lifetime.h"
#include "chrome/browser/net/chrome_network_delegate.h"
#include "chrome/browser/profiles/profile.h"
@@ -748,6 +749,13 @@ void ChromeBrowserMainPartsChromeos::PostProfileInit() {
manager->SetState(session_manager->GetDefaultIMEState(profile()));
+ // Show postponed extension error messages (if any) if it is the active user
+ // profile. Because extension errors are always reported in context of active
+ // user, it's safe to display the message boxes after input methods of the
+ // active user is initialized.
+ if (ProfileHelper::Get()->GetUserByProfile(profile())->is_active())
xiyuan 2017/04/24 18:21:51 Most of the time (i.e. NOT the crash-n-restart cas
Wenzhao (Colin) Zang 2017/04/25 22:06:32 Done.
+ ExtensionErrorReporter::GetInstance()->ShowPostponedMessages();
+
bool is_running_test = parameters().ui_task != nullptr;
g_browser_process->platform_part()->session_manager()->Initialize(
parsed_command_line(), profile(), is_running_test);

Powered by Google App Engine
This is Rietveld 408576698