Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5903)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 2806603003: WebUI: prevent WebContent to hold an invalid pointer. (Closed)
Patch Set: Better ownership semantics Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
index 9c7a8f80956fe6b94b2e282a002f934e2af67f11..6898f7f40dc1eeac21060dba82470ae173e6f458 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
@@ -654,8 +654,11 @@ void PrintPreviewUI::OnHidePreviewDialog() {
ConstrainedWebDialogDelegate* delegate = GetConstrainedDelegate();
if (!delegate)
return;
- delegate->ReleaseWebContentsOnDialogClose();
- background_printing_manager->OwnPrintPreviewDialog(preview_dialog);
+ std::unique_ptr<content::WebContents> preview_contents =
+ delegate->ReleaseWebContents();
+ DCHECK_EQ(preview_dialog, preview_contents.get());
+ background_printing_manager->OwnPrintPreviewDialog(
+ preview_contents.release());
OnClosePrintPreviewDialog();
}
« no previous file with comments | « chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698