Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2806603003: WebUI: prevent WebContent to hold an invalid pointer. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: prevent WebContent to hold an invalid pointer. Based on https://codereview.chromium.org/2798583002/

Patch Set 1 #

Patch Set 2 : Better ownership semantics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -34 lines) Patch
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 1 4 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 6 chunks +23 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
Lei Zhang
3 years, 8 months ago (2017-04-10 18:07:27 UTC) #1
Description was changed from

==========
WebUI: prevent WebContent to hold an invalid pointer.

Based on https://codereview.chromium.org/2798583002/
==========

to

==========
WebUI: prevent WebContent to hold an invalid pointer.

Based on https://codereview.chromium.org/2798583002/
==========

Powered by Google App Engine
This is Rietveld 408576698