Issue 28066: Experimental: fix two issues with ARM fast (jump table) switches....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28066: Experimental: fix two issues with ARM fast (jump table) switches.... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: fix two issues with ARM fast (jump table) switches. (1) do not emit the jump table twice, (2) do bind the break target. Committed: http://code.google.com/p/v8/source/detail?r=1346

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -18 lines)			Patch
	M	src/codegen-arm.cc	View		2 chunks	+25 lines, -10 lines	2 comments	Download
	M	test/mjsunit/compare-constants.js	View	1	3 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/28066/diff/6/1002 File src/codegen-arm.cc (right): http://codereview.chromium.org/28066/diff/6/1002#newcode1498 Line 1498: // it. This comment should be more ...

11 years, 10 months ago (2009-02-24 11:55:06 UTC) #2

Kevin Millikin (Chromium)

11 years, 10 months ago (2009-02-24 12:33:19 UTC) #3

http://codereview.chromium.org/28066/diff/6/1002
File src/codegen-arm.cc (right):

http://codereview.chromium.org/28066/diff/6/1002#newcode1498
Line 1498: // it.
On 2009/02/24 11:55:06, Lasse Reichstein wrote:
> This comment should be more descriptive.

Descriptified.

Expand Messages | Collapse Messages