Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3388)

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.cc

Issue 2806583002: reland: cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/ui/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.cc b/chrome/browser/chromeos/login/ui/webui_login_view.cc
index 594d1a88cc2ee6da2e478a5787b16998483fb926..5508d0aa3fee29fefd9ef6714e434ad5eeacd7c0 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.cc
@@ -457,10 +457,12 @@ bool WebUILoginView::TakeFocus(content::WebContents* source, bool reverse) {
return true;
ash::SystemTray* tray = ash::Shell::Get()->GetPrimarySystemTray();
- if (tray && tray->GetWidget()->IsVisible()) {
+ if (tray && tray->GetWidget()->IsVisible() && tray->visible()) {
tray->SetNextFocusableView(this);
ash::Shell::Get()->focus_cycler()->RotateFocus(
reverse ? ash::FocusCycler::BACKWARD : ash::FocusCycler::FORWARD);
+ } else {
+ AboutToRequestFocusFromTabTraversal(reverse);
}
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698