Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2806543002: Issue 29186. Make several top-level variables explicitly 'dynamic'. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/corelib_strong/error_stack_trace2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/inferrer_constructor3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/language_strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib_strong/html/input_element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/lib_strong.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-06 17:25:23 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-06 17:34:50 UTC) #2
scheglov
3 years, 8 months ago (2017-04-06 17:57:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7cd782db6e579ad8a8a218f79b26073caad9c91c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698