Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2211)

Unified Diff: base/task_scheduler/scheduler_worker_stack_unittest.cc

Issue 2806413002: Separate the create and start phases in SchedulerSingleThreadTaskRunnerManager. (Closed)
Patch Set: CR-robliao-45-initial-state-comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.cc ('k') | base/task_scheduler/scheduler_worker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_stack_unittest.cc
diff --git a/base/task_scheduler/scheduler_worker_stack_unittest.cc b/base/task_scheduler/scheduler_worker_stack_unittest.cc
index b7d57ff1ef16623d7c0acb35e5af7e5efb7ae795..426bc6f54ddbf831883f43e41433e018f4a648b9 100644
--- a/base/task_scheduler/scheduler_worker_stack_unittest.cc
+++ b/base/task_scheduler/scheduler_worker_stack_unittest.cc
@@ -44,29 +44,20 @@ class MockSchedulerWorkerDelegate : public SchedulerWorker::Delegate {
class TaskSchedulerWorkerStackTest : public testing::Test {
protected:
void SetUp() override {
- worker_a_ = SchedulerWorker::Create(
- ThreadPriority::NORMAL,
- WrapUnique(new MockSchedulerWorkerDelegate), &task_tracker_,
- SchedulerWorker::InitialState::ALIVE);
+ worker_a_ = make_scoped_refptr(new SchedulerWorker(
+ ThreadPriority::NORMAL, WrapUnique(new MockSchedulerWorkerDelegate),
+ &task_tracker_));
ASSERT_TRUE(worker_a_);
- worker_b_ = SchedulerWorker::Create(
- ThreadPriority::NORMAL,
- WrapUnique(new MockSchedulerWorkerDelegate), &task_tracker_,
- SchedulerWorker::InitialState::ALIVE);
+ worker_b_ = make_scoped_refptr(new SchedulerWorker(
+ ThreadPriority::NORMAL, WrapUnique(new MockSchedulerWorkerDelegate),
+ &task_tracker_));
ASSERT_TRUE(worker_b_);
- worker_c_ = SchedulerWorker::Create(
- ThreadPriority::NORMAL,
- WrapUnique(new MockSchedulerWorkerDelegate), &task_tracker_,
- SchedulerWorker::InitialState::ALIVE);
+ worker_c_ = make_scoped_refptr(new SchedulerWorker(
+ ThreadPriority::NORMAL, WrapUnique(new MockSchedulerWorkerDelegate),
+ &task_tracker_));
ASSERT_TRUE(worker_c_);
}
- void TearDown() override {
- worker_a_->JoinForTesting();
- worker_b_->JoinForTesting();
- worker_c_->JoinForTesting();
- }
-
scoped_refptr<SchedulerWorker> worker_a_;
scoped_refptr<SchedulerWorker> worker_b_;
scoped_refptr<SchedulerWorker> worker_c_;
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.cc ('k') | base/task_scheduler/scheduler_worker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698