Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2806353005: Drop the 'analyzeWithoutTasks' flag for AnalysisDriver. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop the 'analyzeWithoutTasks' flag for AnalysisDriver. We're not going back, I think. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2c46a154b86579a29fe5f1413c6956e9aa03ef39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -38 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 3 chunks +21 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-10 21:48:33 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-10 22:08:32 UTC) #2
scheglov
3 years, 8 months ago (2017-04-10 23:57:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c46a154b86579a29fe5f1413c6956e9aa03ef39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698