Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: components/password_manager/content/browser/credential_manager_impl_unittest.cc

Issue 2806293005: Fix a DCHECK in HttpPasswordStoreMigrator for localhost. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/credential_manager_impl_unittest.cc
diff --git a/components/password_manager/content/browser/credential_manager_impl_unittest.cc b/components/password_manager/content/browser/credential_manager_impl_unittest.cc
index 4032c5227fec4a613add5a87f825e19488a2358b..9563fc28c69add8b0a0376b41162f8824a27c484 100644
--- a/components/password_manager/content/browser/credential_manager_impl_unittest.cc
+++ b/components/password_manager/content/browser/credential_manager_impl_unittest.cc
@@ -1468,6 +1468,14 @@ TEST_F(CredentialManagerImplTest, ZeroClickAfterMigratingHttpCredential) {
CredentialType::CREDENTIAL_TYPE_PASSWORD);
}
+TEST_F(CredentialManagerImplTest, MigrateWithEmptyStore) {
+ // HTTP scheme is valid for localhost. Nothing should crash.
+ NavigateAndCommit(GURL("http://127.0.0.1:8000/"));
+
+ std::vector<GURL> federations;
+ ExpectZeroClickSignInFailure(false, true, federations);
+}
+
TEST_F(CredentialManagerImplTest, GetSynthesizedFormForOrigin) {
PasswordStore::FormDigest synthesized =
cm_service_impl_->GetSynthesizedFormForOrigin();
« no previous file with comments | « no previous file | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698