Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2106)

Unified Diff: chrome/browser/content_settings/host_content_settings_map_unittest.cc

Issue 2806283002: Revert of Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/host_content_settings_map_unittest.cc
diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
index 6b07d537d453c8ef6abc7a22aa97ff0c3f727cc6..93378da804c657a62c67cc5617fda586913494b3 100644
--- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc
+++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
@@ -4,7 +4,6 @@
#include <memory>
#include <string>
-#include <utility>
#include "base/auto_reset.h"
#include "base/command_line.h"
@@ -986,10 +985,10 @@
base::DictionaryValue* all_settings_dictionary = update.Get();
ASSERT_TRUE(NULL != all_settings_dictionary);
- auto dummy_payload = base::MakeUnique<base::DictionaryValue>();
+ base::DictionaryValue* dummy_payload = new base::DictionaryValue;
dummy_payload->SetInteger("setting", CONTENT_SETTING_ALLOW);
all_settings_dictionary->SetWithoutPathExpansion("[*.]\xC4\x87ira.com,*",
- std::move(dummy_payload));
+ dummy_payload);
}
HostContentSettingsMapFactory::GetForProfile(&profile);
@@ -1521,10 +1520,10 @@
base::DictionaryValue* all_settings_dictionary = update.Get();
ASSERT_TRUE(NULL != all_settings_dictionary);
- auto domain_setting = base::MakeUnique<base::DictionaryValue>();
+ base::DictionaryValue* domain_setting = new base::DictionaryValue;
domain_setting->SetInteger("setting", CONTENT_SETTING_ALLOW);
all_settings_dictionary->SetWithoutPathExpansion(host_pattern_string + ",*",
- std::move(domain_setting));
+ domain_setting);
}
const base::DictionaryValue* all_settings_dictionary =

Powered by Google App Engine
This is Rietveld 408576698