Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4483)

Unified Diff: chrome/common/extensions/sync_type_unittest.cc

Issue 2806283002: Revert of Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/sync_type_unittest.cc
diff --git a/chrome/common/extensions/sync_type_unittest.cc b/chrome/common/extensions/sync_type_unittest.cc
index b2fbaa4c431b8753d6f87da4d9619bb38feff754..512ad30e2ca1e3e0a0f485dd9bb3adbabfa7eca2 100644
--- a/chrome/common/extensions/sync_type_unittest.cc
+++ b/chrome/common/extensions/sync_type_unittest.cc
@@ -2,10 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <utility>
-
#include "base/files/file_path.h"
-#include "base/memory/ptr_util.h"
#include "build/build_config.h"
#include "chrome/common/extensions/sync_helper.h"
#include "extensions/common/error_utils.h"
@@ -59,16 +56,16 @@
if (num_plugins >= 0) {
base::ListValue* plugins = new base::ListValue();
for (int i = 0; i < num_plugins; ++i) {
- auto plugin = base::MakeUnique<base::DictionaryValue>();
+ base::DictionaryValue* plugin = new base::DictionaryValue();
plugin->SetString(keys::kPluginsPath, std::string());
- plugins->Set(i, std::move(plugin));
+ plugins->Set(i, plugin);
}
source.Set(keys::kPlugins, plugins);
}
}
if (has_plugin_permission) {
base::ListValue* plugins = new base::ListValue();
- plugins->Set(0, base::MakeUnique<base::Value>("plugin"));
+ plugins->Set(0, new base::Value("plugin"));
source.Set(keys::kPermissions, plugins);
}
« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698