Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: chrome/browser/extensions/api/cookies/cookies_unittest.cc

Issue 2806283002: Revert of Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Tests common functionality used by the Chrome Extensions Cookies API 5 // Tests common functionality used by the Chrome Extensions Cookies API
6 // implementation. 6 // implementation.
7 7
8 #include "testing/gtest/include/gtest/gtest.h"
9
8 #include <stddef.h> 10 #include <stddef.h>
9 11
10 #include <utility>
11
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/memory/ptr_util.h"
14 #include "base/values.h" 13 #include "base/values.h"
15 #include "chrome/browser/extensions/api/cookies/cookies_api_constants.h" 14 #include "chrome/browser/extensions/api/cookies/cookies_api_constants.h"
16 #include "chrome/browser/extensions/api/cookies/cookies_helpers.h" 15 #include "chrome/browser/extensions/api/cookies/cookies_helpers.h"
17 #include "chrome/common/extensions/api/cookies.h" 16 #include "chrome/common/extensions/api/cookies.h"
18 #include "chrome/test/base/testing_profile.h" 17 #include "chrome/test/base/testing_profile.h"
19 #include "content/public/test/test_browser_thread_bundle.h" 18 #include "content/public/test/test_browser_thread_bundle.h"
20 #include "net/cookies/canonical_cookie.h" 19 #include "net/cookies/canonical_cookie.h"
21 #include "net/cookies/cookie_constants.h" 20 #include "net/cookies/cookie_constants.h"
22 #include "testing/gtest/include/gtest/gtest.h"
23 #include "url/gurl.h" 21 #include "url/gurl.h"
24 22
25 using extensions::api::cookies::Cookie; 23 using extensions::api::cookies::Cookie;
26 using extensions::api::cookies::CookieStore; 24 using extensions::api::cookies::CookieStore;
27 25
28 namespace GetAll = extensions::api::cookies::GetAll; 26 namespace GetAll = extensions::api::cookies::GetAll;
29 27
30 namespace extensions { 28 namespace extensions {
31 29
32 namespace keys = cookies_api_constants; 30 namespace keys = cookies_api_constants;
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 ASSERT_NE(nullptr, canonical_cookie2.get()); 112 ASSERT_NE(nullptr, canonical_cookie2.get());
115 Cookie cookie2 = 113 Cookie cookie2 =
116 cookies_helpers::CreateCookie(*canonical_cookie2, "some cookie store"); 114 cookies_helpers::CreateCookie(*canonical_cookie2, "some cookie store");
117 EXPECT_FALSE(cookie2.host_only); 115 EXPECT_FALSE(cookie2.host_only);
118 EXPECT_FALSE(cookie2.session); 116 EXPECT_FALSE(cookie2.session);
119 EXPECT_EQ(api::cookies::SAME_SITE_STATUS_STRICT, cookie2.same_site); 117 EXPECT_EQ(api::cookies::SAME_SITE_STATUS_STRICT, cookie2.same_site);
120 ASSERT_TRUE(cookie2.expiration_date.get()); 118 ASSERT_TRUE(cookie2.expiration_date.get());
121 EXPECT_EQ(10000, *cookie2.expiration_date); 119 EXPECT_EQ(10000, *cookie2.expiration_date);
122 120
123 TestingProfile profile; 121 TestingProfile profile;
124 auto tab_ids_list = base::MakeUnique<base::ListValue>(); 122 base::ListValue* tab_ids_list = new base::ListValue();
125 std::vector<int> tab_ids; 123 std::vector<int> tab_ids;
126 CookieStore cookie_store = 124 CookieStore cookie_store =
127 cookies_helpers::CreateCookieStore(&profile, std::move(tab_ids_list)); 125 cookies_helpers::CreateCookieStore(&profile, tab_ids_list);
128 EXPECT_EQ("0", cookie_store.id); 126 EXPECT_EQ("0", cookie_store.id);
129 EXPECT_EQ(tab_ids, cookie_store.tab_ids); 127 EXPECT_EQ(tab_ids, cookie_store.tab_ids);
130 } 128 }
131 129
132 TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) { 130 TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) {
133 std::unique_ptr<net::CanonicalCookie> cookie1(net::CanonicalCookie::Create( 131 std::unique_ptr<net::CanonicalCookie> cookie1(net::CanonicalCookie::Create(
134 GURL("http://example.com"), "ABC", "DEF", "example.com", "/", 132 GURL("http://example.com"), "ABC", "DEF", "example.com", "/",
135 base::Time(), base::Time(), false, false, 133 base::Time(), base::Time(), false, false,
136 net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT)); 134 net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
137 ASSERT_NE(nullptr, cookie1.get()); 135 ASSERT_NE(nullptr, cookie1.get());
(...skipping 25 matching lines...) Expand all
163 {".bar.com", "http://bar.com", "bar.com", true}, 161 {".bar.com", "http://bar.com", "bar.com", true},
164 {"bar.com", "http://foo.bar.com", "", true}, 162 {"bar.com", "http://foo.bar.com", "", true},
165 {"bar.com", "http://bar.foo.com", "", false}, 163 {"bar.com", "http://bar.foo.com", "", false},
166 {".bar.com", "http://foo.bar.com", ".foo.bar.com", true}, 164 {".bar.com", "http://foo.bar.com", ".foo.bar.com", true},
167 {".bar.com", "http://baz.foo.bar.com", "", true}, 165 {".bar.com", "http://baz.foo.bar.com", "", true},
168 {"foo.bar.com", "http://bar.com", ".bar.com", false}}; 166 {"foo.bar.com", "http://bar.com", ".bar.com", false}};
169 167
170 for (size_t i = 0; i < arraysize(tests); ++i) { 168 for (size_t i = 0; i < arraysize(tests); ++i) {
171 // Build up the Params struct. 169 // Build up the Params struct.
172 base::ListValue args; 170 base::ListValue args;
173 auto dict = base::MakeUnique<base::DictionaryValue>(); 171 base::DictionaryValue* dict = new base::DictionaryValue();
174 dict->SetString(keys::kDomainKey, std::string(tests[i].filter)); 172 dict->SetString(keys::kDomainKey, std::string(tests[i].filter));
175 args.Set(0, std::move(dict)); 173 args.Set(0, dict);
176 std::unique_ptr<GetAll::Params> params(GetAll::Params::Create(args)); 174 std::unique_ptr<GetAll::Params> params(GetAll::Params::Create(args));
177 175
178 cookies_helpers::MatchFilter filter(&params->details); 176 cookies_helpers::MatchFilter filter(&params->details);
179 std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create( 177 std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
180 GURL(tests[i].url), std::string(), std::string(), tests[i].domain, 178 GURL(tests[i].url), std::string(), std::string(), tests[i].domain,
181 std::string(), base::Time(), base::Time(), false, false, 179 std::string(), base::Time(), base::Time(), false, false,
182 net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT)); 180 net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
183 ASSERT_NE(nullptr, cookie.get()); 181 ASSERT_NE(nullptr, cookie.get());
184 EXPECT_EQ(tests[i].matches, filter.MatchesCookie(*cookie)); 182 EXPECT_EQ(tests[i].matches, filter.MatchesCookie(*cookie));
185 } 183 }
186 } 184 }
187 185
188 TEST_F(ExtensionCookiesTest, DecodeUTF8WithErrorHandling) { 186 TEST_F(ExtensionCookiesTest, DecodeUTF8WithErrorHandling) {
189 std::unique_ptr<net::CanonicalCookie> canonical_cookie( 187 std::unique_ptr<net::CanonicalCookie> canonical_cookie(
190 net::CanonicalCookie::Create(GURL("http://test.com"), 188 net::CanonicalCookie::Create(GURL("http://test.com"),
191 "=011Q255bNX_1!yd\203e+;path=/path\203", 189 "=011Q255bNX_1!yd\203e+;path=/path\203",
192 base::Time(), net::CookieOptions())); 190 base::Time(), net::CookieOptions()));
193 ASSERT_NE(nullptr, canonical_cookie.get()); 191 ASSERT_NE(nullptr, canonical_cookie.get());
194 Cookie cookie = 192 Cookie cookie =
195 cookies_helpers::CreateCookie(*canonical_cookie, "some cookie store"); 193 cookies_helpers::CreateCookie(*canonical_cookie, "some cookie store");
196 EXPECT_EQ(std::string("011Q255bNX_1!yd\xEF\xBF\xBD" 194 EXPECT_EQ(std::string("011Q255bNX_1!yd\xEF\xBF\xBD"
197 "e+"), 195 "e+"),
198 cookie.value); 196 cookie.value);
199 EXPECT_EQ(std::string(), cookie.path); 197 EXPECT_EQ(std::string(), cookie.path);
200 } 198 }
201 199
202 } // namespace extensions 200 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_helpers.cc ('k') | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698