Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 2806273002: Make the Translate Overflow Menu using ListPopupWindow (Closed)
Patch Set: Fix according to comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources> 6 <resources>
7 <!-- Connection info popup dimensions --> 7 <!-- Connection info popup dimensions -->
8 <dimen name="connection_info_padding_wide">24dp</dimen> 8 <dimen name="connection_info_padding_wide">24dp</dimen>
9 <dimen name="connection_info_padding_thin">16dp</dimen> 9 <dimen name="connection_info_padding_thin">16dp</dimen>
10 10
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 <dimen name="infobar_small_icon_size">24dp</dimen> 95 <dimen name="infobar_small_icon_size">24dp</dimen>
96 <dimen name="infobar_small_icon_margin">8dp</dimen> 96 <dimen name="infobar_small_icon_margin">8dp</dimen>
97 <dimen name="infobar_big_icon_size">48dp</dimen> 97 <dimen name="infobar_big_icon_size">48dp</dimen>
98 <dimen name="infobar_big_icon_margin">16dp</dimen> 98 <dimen name="infobar_big_icon_margin">16dp</dimen>
99 99
100 <!-- Dimensions for compact infobars are a little shorter. --> 100 <!-- Dimensions for compact infobars are a little shorter. -->
101 <dimen name="infobar_compact_size">48dp</dimen> 101 <dimen name="infobar_compact_size">48dp</dimen>
102 102
103 <!-- Dimensions for compact translate infobar. --> 103 <!-- Dimensions for compact translate infobar. -->
104 <dimen name="infobar_translate_fade_edge_length">18dp</dimen> 104 <dimen name="infobar_translate_fade_edge_length">18dp</dimen>
105 <dimen name="infobar_translate_menu_width">260dp</dimen>
Marti Wong 2017/04/12 02:13:42 menu width is 260dp according to the static specs.
gone 2017/04/12 17:17:33 that doesn't work for all languages, does it? it
Marti Wong 2017/04/13 02:02:12 I will do the followup in my next CL for this widt
105 106
106 <!-- Contextual search dimensions --> 107 <!-- Contextual search dimensions -->
107 <dimen name="contextual_search_peek_promo_height">48dp</dimen> 108 <dimen name="contextual_search_peek_promo_height">48dp</dimen>
108 <dimen name="contextual_search_peek_promo_padding">12dp</dimen> 109 <dimen name="contextual_search_peek_promo_padding">12dp</dimen>
109 <dimen name="contextual_search_caption_text_size">14sp</dimen> 110 <dimen name="contextual_search_caption_text_size">14sp</dimen>
110 <dimen name="contextual_search_bar_image_size">36dp</dimen> 111 <dimen name="contextual_search_bar_image_size">36dp</dimen>
111 <!-- The following two dimensions were taking from the UI specs for contextu al search, where 112 <!-- The following two dimensions were taking from the UI specs for contextu al search, where
112 they were 36dp and 3dp respectively, but have been updated to allow for padd ing around 113 they were 36dp and 3dp respectively, but have been updated to allow for padd ing around
113 TextViews that we cannot get rid of. --> 114 TextViews that we cannot get rid of. -->
114 <dimen name="contextual_search_text_layer_min_height">38dp</dimen> 115 <dimen name="contextual_search_text_layer_min_height">38dp</dimen>
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 <dimen name="action_bar_shadow_height">10dp</dimen> 453 <dimen name="action_bar_shadow_height">10dp</dimen>
453 <dimen name="card_corner_radius">2dp</dimen> 454 <dimen name="card_corner_radius">2dp</dimen>
454 <dimen name="list_item_corner_radius">3dp</dimen> 455 <dimen name="list_item_corner_radius">3dp</dimen>
455 <dimen name="list_item_lateral_padding">1dp</dimen> 456 <dimen name="list_item_lateral_padding">1dp</dimen>
456 <dimen name="history_default_text_margin">16dp</dimen> 457 <dimen name="history_default_text_margin">16dp</dimen>
457 458
458 <!-- Context Menu Dimensions --> 459 <!-- Context Menu Dimensions -->
459 <dimen name="context_menu_header_image_min_size">56dp</dimen> 460 <dimen name="context_menu_header_image_min_size">56dp</dimen>
460 <dimen name="context_menu_header_image_max_size">56dp</dimen> 461 <dimen name="context_menu_header_image_max_size">56dp</dimen>
461 </resources> 462 </resources>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698